Re: [Xen-devel] [PATCH v2] x86/PoD: shorten certain operations on higher order ranges

2015-09-30 Thread Jan Beulich
>>> On 29.09.15 at 18:45, wrote: > On Mon, Sep 28, 2015 at 3:30 PM, Jan Beulich wrote: >> Now that p2m->get_entry() always returns a valid order, utilize this >> to accelerate some of the operations in PoD code. (There are two uses >> of

Re: [Xen-devel] [PATCH v2] x86/PoD: shorten certain operations on higher order ranges

2015-09-30 Thread George Dunlap
On 30/09/15 13:12, Jan Beulich wrote: On 29.09.15 at 18:45, wrote: >> On Mon, Sep 28, 2015 at 3:30 PM, Jan Beulich wrote: >>> Now that p2m->get_entry() always returns a valid order, utilize this >>> to accelerate some of the operations in PoD

Re: [Xen-devel] [PATCH v2] x86/PoD: shorten certain operations on higher order ranges

2015-09-30 Thread Jan Beulich
>>> On 30.09.15 at 16:23, wrote: > On 30/09/15 13:12, Jan Beulich wrote: > On 29.09.15 at 18:45, wrote: >>> On Mon, Sep 28, 2015 at 3:30 PM, Jan Beulich wrote: Now that p2m->get_entry() always returns a valid

Re: [Xen-devel] [PATCH v2] x86/PoD: shorten certain operations on higher order ranges

2015-09-29 Thread Andrew Cooper
On 28/09/15 15:30, Jan Beulich wrote: > Now that p2m->get_entry() always returns a valid order, utilize this > to accelerate some of the operations in PoD code. (There are two uses > of p2m->get_entry() left which don't easily lend themselves to this > optimization.) > > Also adjust a few types as

Re: [Xen-devel] [PATCH v2] x86/PoD: shorten certain operations on higher order ranges

2015-09-29 Thread George Dunlap
On 28/09/15 15:30, Jan Beulich wrote: > Now that p2m->get_entry() always returns a valid order, utilize this > to accelerate some of the operations in PoD code. (There are two uses > of p2m->get_entry() left which don't easily lend themselves to this > optimization.) > > Also adjust a few types

Re: [Xen-devel] [PATCH v2] x86/PoD: shorten certain operations on higher order ranges

2015-09-29 Thread Jan Beulich
>>> On 29.09.15 at 14:20, wrote: > On 28/09/15 15:30, Jan Beulich wrote: >> --- a/xen/arch/x86/mm/p2m-pod.c >> +++ b/xen/arch/x86/mm/p2m-pod.c >> @@ -119,20 +119,23 @@ p2m_pod_cache_add(struct p2m_domain *p2m >> >> unlock_page_alloc(p2m); >> >> -/* Then add

Re: [Xen-devel] [PATCH v2] x86/PoD: shorten certain operations on higher order ranges

2015-09-29 Thread Andrew Cooper
On 29/09/15 13:57, Jan Beulich wrote: On 29.09.15 at 14:20, wrote: >> On 28/09/15 15:30, Jan Beulich wrote: >>> --- a/xen/arch/x86/mm/p2m-pod.c >>> +++ b/xen/arch/x86/mm/p2m-pod.c >>> @@ -119,20 +119,23 @@ p2m_pod_cache_add(struct p2m_domain *p2m >>> >>>

Re: [Xen-devel] [PATCH v2] x86/PoD: shorten certain operations on higher order ranges

2015-09-29 Thread George Dunlap
On Mon, Sep 28, 2015 at 3:30 PM, Jan Beulich wrote: > Now that p2m->get_entry() always returns a valid order, utilize this > to accelerate some of the operations in PoD code. (There are two uses > of p2m->get_entry() left which don't easily lend themselves to this >

[Xen-devel] [PATCH v2] x86/PoD: shorten certain operations on higher order ranges

2015-09-28 Thread Jan Beulich
Now that p2m->get_entry() always returns a valid order, utilize this to accelerate some of the operations in PoD code. (There are two uses of p2m->get_entry() left which don't easily lend themselves to this optimization.) Also adjust a few types as needed and remove stale comments from