Re: [Xen-devel] [PATCH v2] x86/mm: pod: Use the correct memory flags for alloc_domheap_page{, s}

2015-10-26 Thread George Dunlap
On 23/10/15 11:33, Julien Grall wrote: > The last parameter of alloc_domheap_page{s,} contain the memory flags and > not the order of the allocation. > > Use 0 for the call in p2m_pod_set_cache_target as it was before > 1069d63c5ef2510d08b83b2171af660e5bb18c63 "x86/mm/p2m: use defines for > page

Re: [Xen-devel] [PATCH v2] x86/mm: pod: Use the correct memory flags for alloc_domheap_page{, s}

2015-10-26 Thread Jan Beulich
>>> On 26.10.15 at 11:29, wrote: > On 23/10/15 11:33, Julien Grall wrote: >> Note that the patch has only been build tested. > > It would be nice if we could properly test the codepath in question > before checking it in, but we have lots of time before the release for

Re: [Xen-devel] [PATCH v2] x86/mm: pod: Use the correct memory flags for alloc_domheap_page{, s}

2015-10-26 Thread George Dunlap
On 26/10/15 10:40, Jan Beulich wrote: On 26.10.15 at 11:29, wrote: >> On 23/10/15 11:33, Julien Grall wrote: >>> Note that the patch has only been build tested. >> >> It would be nice if we could properly test the codepath in question >> before checking it in, but

[Xen-devel] [PATCH v2] x86/mm: pod: Use the correct memory flags for alloc_domheap_page{, s}

2015-10-23 Thread Julien Grall
The last parameter of alloc_domheap_page{s,} contain the memory flags and not the order of the allocation. Use 0 for the call in p2m_pod_set_cache_target as it was before 1069d63c5ef2510d08b83b2171af660e5bb18c63 "x86/mm/p2m: use defines for page sizes". Note that PAGE_ORDER_4K is also equal to 0

Re: [Xen-devel] [PATCH v2] x86/mm: pod: Use the correct memory flags for alloc_domheap_page{, s}

2015-10-23 Thread Dario Faggioli
On Fri, 2015-10-23 at 11:33 +0100, Julien Grall wrote: > The last parameter of alloc_domheap_page{s,} contain the memory flags > and > not the order of the allocation. > > Use 0 for the call in p2m_pod_set_cache_target as it was before > 1069d63c5ef2510d08b83b2171af660e5bb18c63 "x86/mm/p2m: use