Re: [Xen-devel] [PATCH v2] x86: Fixup IRQs when CPUs go down during shutdown

2015-12-04 Thread Andrew Cooper
On 02/12/15 15:30, Jan Beulich wrote: On 02.12.15 at 16:09, wrote: >> On 12/02/2015 02:02 PM, Jan Beulich wrote: >> On 02.12.15 at 14:46, wrote: --- a/xen/arch/x86/smp.c +++ b/xen/arch/x86/smp.c @@ -286,6 +286,7 @@

Re: [Xen-devel] [PATCH v2] x86: Fixup IRQs when CPUs go down during shutdown

2015-12-02 Thread Ross Lagerwall
On 12/02/2015 02:02 PM, Jan Beulich wrote: On 02.12.15 at 14:46, wrote: Commit fc0c3fa2ad5c ("x86/IO-APIC: fix setup of Xen internally used IRQs (take 2)") introduced a regression on some hardware where Xen would hang during shutdown, repeating the following message:

Re: [Xen-devel] [PATCH v2] x86: Fixup IRQs when CPUs go down during shutdown

2015-12-02 Thread Jan Beulich
>>> On 02.12.15 at 16:09, wrote: > On 12/02/2015 02:02 PM, Jan Beulich wrote: > On 02.12.15 at 14:46, wrote: >>> --- a/xen/arch/x86/smp.c >>> +++ b/xen/arch/x86/smp.c >>> @@ -286,6 +286,7 @@ void __stop_this_cpu(void) >>> >>> static

[Xen-devel] [PATCH v2] x86: Fixup IRQs when CPUs go down during shutdown

2015-12-02 Thread Ross Lagerwall
Commit fc0c3fa2ad5c ("x86/IO-APIC: fix setup of Xen internally used IRQs (take 2)") introduced a regression on some hardware where Xen would hang during shutdown, repeating the following message: APIC error on CPU0: 08(08), Receive accept error This appears to be because an interrupt (in this

Re: [Xen-devel] [PATCH v2] x86: Fixup IRQs when CPUs go down during shutdown

2015-12-02 Thread Andrew Cooper
On 02/12/15 13:46, Ross Lagerwall wrote: > @@ -298,6 +299,13 @@ static void stop_this_cpu(void *dummy) > void smp_send_stop(void) > { > int timeout = 10; > +cpumask_t online; > + > +cpumask_clear(); > +cpumask_set_cpu(smp_processor_id(), ); You can avoid this intermediate

Re: [Xen-devel] [PATCH v2] x86: Fixup IRQs when CPUs go down during shutdown

2015-12-02 Thread Jan Beulich
>>> On 02.12.15 at 14:46, wrote: > Commit fc0c3fa2ad5c ("x86/IO-APIC: fix setup of Xen internally used IRQs > (take 2)") introduced a regression on some hardware where Xen would hang > during shutdown, repeating the following message: > APIC error on CPU0: 08(08),