Re: [Xen-devel] [PATCH v2] xen/gntdev: Use mempolicy instead of VM_IO flag to avoid NUMA balancing

2016-11-17 Thread Boris Ostrovsky
On 11/17/2016 11:01 AM, Olaf Hering wrote: > On Thu, Nov 17, Boris Ostrovsky wrote: > >> On 11/17/2016 06:28 AM, Olaf Hering wrote: >>> ERROR: "__mpol_dup" [drivers/xen/xen-gntdev.ko] undefined! >>> ERROR: "get_task_policy" [drivers/xen/xen-gntdev.ko] undefined! >> I just built 4.4.11 with this

Re: [Xen-devel] [PATCH v2] xen/gntdev: Use mempolicy instead of VM_IO flag to avoid NUMA balancing

2016-11-17 Thread Olaf Hering
On Thu, Nov 17, Boris Ostrovsky wrote: > On 11/17/2016 06:28 AM, Olaf Hering wrote: > > ERROR: "__mpol_dup" [drivers/xen/xen-gntdev.ko] undefined! > > ERROR: "get_task_policy" [drivers/xen/xen-gntdev.ko] undefined! > I just built 4.4.11 with this patch applied and haven't had any problems. Are

Re: [Xen-devel] [PATCH v2] xen/gntdev: Use mempolicy instead of VM_IO flag to avoid NUMA balancing

2016-11-17 Thread Boris Ostrovsky
On 11/17/2016 06:28 AM, Olaf Hering wrote: > On Wed, Nov 16, Boris Ostrovsky wrote: > >> Unfortunately I haven't been able to trigger NUMA balancing >> so while I tested this in general I am not sure I actually >> exercised the code path. > Thanks for the patch! > > Would be nice to actually test

Re: [Xen-devel] [PATCH v2] xen/gntdev: Use mempolicy instead of VM_IO flag to avoid NUMA balancing

2016-11-17 Thread Olaf Hering
On Wed, Nov 16, Boris Ostrovsky wrote: > Unfortunately I haven't been able to trigger NUMA balancing > so while I tested this in general I am not sure I actually > exercised the code path. Thanks for the patch! Would be nice to actually test the code path which caused the initial addition of

[Xen-devel] [PATCH v2] xen/gntdev: Use mempolicy instead of VM_IO flag to avoid NUMA balancing

2016-11-16 Thread Boris Ostrovsky
Commit 9c17d96500f7 ("xen/gntdev: Grant maps should not be subject to NUMA balancing") set VM_IO flag to prevent grant maps from being subjected to NUMA balancing. It was discovered recently that this flag causes get_user_pages() to always fail with -EFAULT. check_vma_flags __get_user_pages