Re: [Xen-devel] [PATCH v2] xen: remove struct domain and vcpu declarations from types.h

2017-08-11 Thread Julien Grall
Hi Wei, On 10/08/17 18:22, Wei Liu wrote: They don't belong there. Removing them causes build errors in several places. Add the forward declarations in those places. Signed-off-by: Wei Liu For ARM: reviewed-by: Julien Grall Cheers, --- Cc:

Re: [Xen-devel] [PATCH v2] xen: remove struct domain and vcpu declarations from types.h

2017-08-11 Thread Wei Liu
On Fri, Aug 11, 2017 at 04:15:59AM -0600, Jan Beulich wrote: > >>> On 10.08.17 at 19:22, wrote: > > --- a/xen/include/asm-x86/xenoprof.h > > +++ b/xen/include/asm-x86/xenoprof.h > > @@ -68,6 +68,8 @@ void passive_domain_destroy(struct vcpu *v); > > > > #else > > > >

Re: [Xen-devel] [PATCH v2] xen: remove struct domain and vcpu declarations from types.h

2017-08-11 Thread Jan Beulich
>>> On 10.08.17 at 19:22, wrote: > --- a/xen/include/asm-x86/xenoprof.h > +++ b/xen/include/asm-x86/xenoprof.h > @@ -68,6 +68,8 @@ void passive_domain_destroy(struct vcpu *v); > > #else > > +struct vcpu; There already is a forward declaration in this header - I'd

[Xen-devel] [PATCH v2] xen: remove struct domain and vcpu declarations from types.h

2017-08-10 Thread Wei Liu
They don't belong there. Removing them causes build errors in several places. Add the forward declarations in those places. Signed-off-by: Wei Liu --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson