Re: [Xen-devel] [PATCH v2 06/10] x86/SVM: Add AVIC vmexit handlers

2017-01-04 Thread Suravee Suthikulpanit
Hi Boris, On 1/3/17 22:34, Boris Ostrovsky wrote: +static int avic_handle_dfr_update(struct vcpu *v) +{ +u32 mod; +struct svm_domain *d = >domain->arch.hvm_domain.svm; +u32 *dfr = avic_get_bk_page_entry(v, APIC_DFR); + +if ( !dfr ) +return -EINVAL; + +mod = (*dfr >>

Re: [Xen-devel] [PATCH v2 06/10] x86/SVM: Add AVIC vmexit handlers

2017-01-04 Thread Suravee Suthikulpanit
Hi Andrew, On 1/3/17 00:28, Andrew Cooper wrote: On 31/12/2016 05:45, Suravee Suthikulpanit wrote: [...] +case AVIC_INCMP_IPI_ERR_INV_TARGET: +dprintk(XENLOG_ERR, +"SVM: %s: Invalid IPI target (icr=%#08x:%08x, idx=%u)\n", +__func__, icrh, icrl,

Re: [Xen-devel] [PATCH v2 06/10] x86/SVM: Add AVIC vmexit handlers

2017-01-03 Thread Boris Ostrovsky
> + > +static int avic_ldr_write(struct vcpu *v, u8 g_phy_id, u32 ldr, bool valid) > +{ > +struct avic_log_apic_id_ent *entry, new_entry; > +u32 *bp = avic_get_bk_page_entry(v, APIC_DFR); dfr would be a better name (and you use it in avic_handle_dfr_update()). Also, 'logical' instead of

Re: [Xen-devel] [PATCH v2 06/10] x86/SVM: Add AVIC vmexit handlers

2017-01-02 Thread Andrew Cooper
On 31/12/2016 05:45, Suravee Suthikulpanit wrote: > VMEXIT_DO_NOACCEL: > This oocurs when a guest access to an APIC register that cannot be "occurs" > accelerated by AVIC. In this case, Xen tries to emulate register accesses. > > This fault is also generated if an EOI isattempted when the

[Xen-devel] [PATCH v2 06/10] x86/SVM: Add AVIC vmexit handlers

2016-12-30 Thread Suravee Suthikulpanit
AVIC introduces two new #vmexit handlers: VMEXIT_INCOMP_IPI: This occurs when an IPI could not be delivered to all targeted guest virtual processors because at least one guest virtual processor was not allocated to a physical core at the time. In this case, Xen would try to emulate IPI.