Re: [Xen-devel] [PATCH v2 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

On Thu, Jan 28, 2016 at 01:58:07PM -0700, Tamas K Lengyel wrote: > The altp2m subsystem in its current form uses its own HVMOP hypercall to set > mem_access permissions, duplicating some of the code already present for > setting regular mem_access permissions. In this patch we consolidate the two

Re: [Xen-devel] [PATCH v2 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

>>> On 01.02.16 at 16:22, wrote: > Ian Campbell writes ("Re: [PATCH v2 1/2] altp2m: Merge > p2m_set_altp2m_mem_access and p2m_set_mem_access"): >> It's unfortunate that we've found ourselves here, but I think rather than >> deprecating the current and adding a new op

Re: [Xen-devel] [PATCH v2 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

>>> On 01.02.16 at 17:30, wrote: > On Mon, 2016-02-01 at 09:21 -0700, Jan Beulich wrote: >> > > > On 01.02.16 at 15:45, wrote: >> > On Fri, 2016-01-29 at 09:47 -0700, Jan Beulich wrote: >> > > > > > On 29.01.16 at 17:32,

Re: [Xen-devel] [PATCH v2 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

Jan Beulich writes ("Re: [PATCH v2 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access"): > On 01.02.16 at 16:22, wrote: > > It's not like we're short of memory op values. > > Are we not? They need to fit in 6 bits (unless we want to play tricks), >

Re: [Xen-devel] [PATCH v2 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

>>> On 01.02.16 at 17:58, wrote: > Jan Beulich writes ("Re: [PATCH v2 1/2] altp2m: Merge > p2m_set_altp2m_mem_access and p2m_set_mem_access"): >> On 01.02.16 at 16:22, wrote: >> > It's not like we're short of memory op values. >> >> Are we

Re: [Xen-devel] [PATCH v2 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

>>> On 01.02.16 at 15:45, wrote: > On Fri, 2016-01-29 at 09:47 -0700, Jan Beulich wrote: >> > > > On 29.01.16 at 17:32, wrote: >> > On Fri, Jan 29, 2016 at 9:19 AM, Jan Beulich wrote: >> > > > > > On 29.01.16 at 17:12,

Re: [Xen-devel] [PATCH v2 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

On Mon, Feb 1, 2016 at 9:21 AM, Jan Beulich wrote: > >>> On 01.02.16 at 15:45, wrote: > > On Fri, 2016-01-29 at 09:47 -0700, Jan Beulich wrote: > >> > > > On 29.01.16 at 17:32, wrote: > >> > On Fri, Jan 29, 2016 at 9:19 AM, Jan

Re: [Xen-devel] [PATCH v2 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

On Mon, 2016-02-01 at 09:21 -0700, Jan Beulich wrote: > > > > On 01.02.16 at 15:45, wrote: > > On Fri, 2016-01-29 at 09:47 -0700, Jan Beulich wrote: > > > > > > On 29.01.16 at 17:32, wrote: > > > > On Fri, Jan 29, 2016 at 9:19 AM, Jan Beulich

Re: [Xen-devel] [PATCH v2 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

>>> On 01.02.16 at 17:35, wrote: > On Mon, Feb 1, 2016 at 9:30 AM, Ian Campbell > wrote: > >> On Mon, 2016-02-01 at 09:21 -0700, Jan Beulich wrote: >> > > > > On 01.02.16 at 15:45, wrote: >> > > On Fri, 2016-01-29 at 09:47

Re: [Xen-devel] [PATCH v2 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

On Fri, 2016-01-29 at 09:47 -0700, Jan Beulich wrote: > > > > On 29.01.16 at 17:32, wrote: > > On Fri, Jan 29, 2016 at 9:19 AM, Jan Beulich wrote: > > > > > > On 29.01.16 at 17:12, wrote: > > > > On Fri, Jan 29, 2016 at 4:03 AM, Jan

Re: [Xen-devel] [PATCH v2 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

Ian Campbell writes ("Re: [PATCH v2 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access"): > It's unfortunate that we've found ourselves here, but I think rather than > deprecating the current and adding a new op alongside we should just accept > the one-time fragility this time

Re: [Xen-devel] [PATCH v2 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

On Mon, Feb 1, 2016 at 9:30 AM, Ian Campbell wrote: > On Mon, 2016-02-01 at 09:21 -0700, Jan Beulich wrote: > > > > > On 01.02.16 at 15:45, wrote: > > > On Fri, 2016-01-29 at 09:47 -0700, Jan Beulich wrote: > > > > > > > On 29.01.16 at 17:32,

Re: [Xen-devel] [PATCH v2 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

>>> On 28.01.16 at 21:58, wrote: > --- a/xen/arch/x86/mm/p2m.c > +++ b/xen/arch/x86/mm/p2m.c > @@ -1777,14 +1777,57 @@ bool_t p2m_mem_access_check(paddr_t gpa, unsigned > long gla, > return (p2ma == p2m_access_n2rwx); > } > > +static int

Re: [Xen-devel] [PATCH v2 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

>>> On 29.01.16 at 17:32, wrote: > On Fri, Jan 29, 2016 at 9:19 AM, Jan Beulich wrote: >> >>> On 29.01.16 at 17:12, wrote: >> > On Fri, Jan 29, 2016 at 4:03 AM, Jan Beulich wrote: >> >> >>> On 28.01.16 at 21:58,

Re: [Xen-devel] [PATCH v2 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

On Fri, Jan 29, 2016 at 9:19 AM, Jan Beulich wrote: > >>> On 29.01.16 at 17:12, wrote: > > On Fri, Jan 29, 2016 at 4:03 AM, Jan Beulich wrote: > >> >>> On 28.01.16 at 21:58, wrote: > >> > ---

Re: [Xen-devel] [PATCH v2 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

On Fri, Jan 29, 2016 at 4:03 AM, Jan Beulich wrote: > >>> On 28.01.16 at 21:58, wrote: > > --- a/xen/arch/x86/mm/p2m.c > > +++ b/xen/arch/x86/mm/p2m.c > > @@ -1777,14 +1777,57 @@ bool_t p2m_mem_access_check(paddr_t gpa, > unsigned long gla, > >

Re: [Xen-devel] [PATCH v2 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

>>> On 29.01.16 at 17:12, wrote: > On Fri, Jan 29, 2016 at 4:03 AM, Jan Beulich wrote: >> >>> On 28.01.16 at 21:58, wrote: >> > --- a/xen/arch/x86/mm/p2m.c >> > +++ b/xen/arch/x86/mm/p2m.c >> > @@ -1777,14 +1777,57 @@ bool_t

[Xen-devel] [PATCH v2 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

The altp2m subsystem in its current form uses its own HVMOP hypercall to set mem_access permissions, duplicating some of the code already present for setting regular mem_access permissions. In this patch we consolidate the two and update the corresponding tools. Signed-off-by: Tamas K Lengyel