Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2017-01-03 Thread Jan Beulich
>>> On 03.01.17 at 15:38, <ian.jack...@eu.citrix.com> wrote: > Jan Beulich writes ("Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict > -Werror checking"): >> Alistair Francis <alistair.fran...@xilinx.com> 12/22/16 8:14 PM >>> >> &

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2017-01-03 Thread Ian Jackson
Jan Beulich writes ("Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking"): > Alistair Francis <alistair.fran...@xilinx.com> 12/22/16 8:14 PM >>> > >Unfortunately the APPEND_CFLAGS=-Wno-error doesn't fix all the issues > >as I still

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2017-01-02 Thread Jan Beulich
>>> On 29.12.16 at 18:30, wrote: > On 29/12/2016 17:10, George Dunlap wrote: >> On Tue, Dec 27, 2016 at 5:07 PM, Andrew Cooper >> wrote: >>> On 27/12/16 15:53, Jan Beulich wrote: >>> "Jan Beulich" 12/27/16 4:42 PM >>>

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-29 Thread Andrew Cooper
On 29/12/2016 17:10, George Dunlap wrote: > On Tue, Dec 27, 2016 at 5:07 PM, Andrew Cooper > wrote: >> On 27/12/16 15:53, Jan Beulich wrote: >> "Jan Beulich" 12/27/16 4:42 PM >>> >> Alistair Francis 12/22/16 8:14

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-29 Thread George Dunlap
On Tue, Dec 27, 2016 at 5:07 PM, Andrew Cooper wrote: > On 27/12/16 15:53, Jan Beulich wrote: > > "Jan Beulich" 12/27/16 4:42 PM >>> > Alistair Francis 12/22/16 8:14 PM >>> Everyone seems fairly

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-27 Thread Andrew Cooper
On 27/12/16 15:53, Jan Beulich wrote: "Jan Beulich" 12/27/16 4:42 PM >>> Alistair Francis 12/22/16 8:14 PM >>> Everyone seems fairly open to an override. Is a environment variable, which if set will disable Werror acceptable? Something like

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-27 Thread Doug Goldstein
On 12/27/16 9:53 AM, Jan Beulich wrote: "Jan Beulich" 12/27/16 4:42 PM >>> Alistair Francis 12/22/16 8:14 PM >>> >>> Everyone seems fairly open to an override. Is a environment variable, >>> which if set will disable Werror acceptable?

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-27 Thread Jan Beulich
>>> "Jan Beulich" 12/27/16 4:42 PM >>> >>> Alistair Francis 12/22/16 8:14 PM >>> >>Everyone seems fairly open to an override. Is a environment variable, >>which if set will disable Werror acceptable? Something like NO_ERROR=Y >>which will result in

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-27 Thread Jan Beulich
>>> Alistair Francis 12/22/16 8:14 PM >>> >On Thu, Dec 22, 2016 at 12:41 AM, Jan Beulich wrote: > On 20.12.16 at 20:46, wrote: >>> Signed-off-by: Alistair Francis >> >> Without some

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-22 Thread Alistair Francis
t 11:22 AM, Ian Jackson >>>>>> <ian.jack...@eu.citrix.com> wrote: >>>>>>> Alistair Francis writes ("Re: [Xen-devel] [PATCH v2 1/5] Remove >>>>>>> hardcoded strict -Werror checking"): >>>>>>>> On Thu,

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-22 Thread Alistair Francis
e: >>>> On Thu, Dec 22, 2016 at 1:12 PM, Alistair Francis >>>> <alistair.fran...@xilinx.com> wrote: >>>>> On Thu, Dec 22, 2016 at 11:22 AM, Ian Jackson >>>>> <ian.jack...@eu.citrix.com> wrote: >>>>>> Alistair Fran

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-22 Thread Doug Goldstein
...@xilinx.com> wrote: >>>> On Thu, Dec 22, 2016 at 11:22 AM, Ian Jackson >>>> <ian.jack...@eu.citrix.com> wrote: >>>>> Alistair Francis writes ("Re: [Xen-devel] [PATCH v2 1/5] Remove >>>>> hardcoded strict -Werror checking"):

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-22 Thread Andrew Cooper
.@eu.citrix.com> wrote: Alistair Francis writes ("Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking"): On Thu, Dec 22, 2016 at 12:41 AM, Jan Beulich <jbeul...@suse.com> wrote: On 20.12.16 at 20:46, <alistair.fran...@xilinx.com> wrote: Signed

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-22 Thread Alistair Francis
te: >>> Alistair Francis writes ("Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded >>> strict -Werror checking"): >>>> On Thu, Dec 22, 2016 at 12:41 AM, Jan Beulich <jbeul...@suse.com> wrote: >>>>> On 20.12.16 at 20:46, <alis

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-22 Thread Alistair Francis
On Thu, Dec 22, 2016 at 1:12 PM, Alistair Francis <alistair.fran...@xilinx.com> wrote: > On Thu, Dec 22, 2016 at 11:22 AM, Ian Jackson <ian.jack...@eu.citrix.com> > wrote: >> Alistair Francis writes ("Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded >> strict

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-22 Thread Alistair Francis
On Thu, Dec 22, 2016 at 11:22 AM, Ian Jackson <ian.jack...@eu.citrix.com> wrote: > Alistair Francis writes ("Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded > strict -Werror checking"): >> On Thu, Dec 22, 2016 at 12:41 AM, Jan Beulich <jbeul...@suse.com&g

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-22 Thread Ian Jackson
Alistair Francis writes ("Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking"): > On Thu, Dec 22, 2016 at 12:41 AM, Jan Beulich <jbeul...@suse.com> wrote: >> On 20.12.16 at 20:46, <alistair.fran...@xilinx.com> wrote: > >> Signed

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-22 Thread Alistair Francis
On Thu, Dec 22, 2016 at 12:41 AM, Jan Beulich wrote: On 20.12.16 at 20:46, wrote: >> Signed-off-by: Alistair Francis > > Without some rationale given I don't think such changes are > acceptable at all. And then,

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-22 Thread Jan Beulich
>>> On 20.12.16 at 20:46, wrote: > Signed-off-by: Alistair Francis Without some rationale given I don't think such changes are acceptable at all. And then, as already pointed out others, the use of -Werror is there not just for fun. If

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-21 Thread Ian Jackson
Doug Goldstein writes ("Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking"): > I agree with you Andrew that its good for kernel/hypervisor development. > I also agree its good for userspace code prior to being committed or > part of a CI loop. Where I wish

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-20 Thread Doug Goldstein
On 12/20/16 2:16 PM, Andrew Cooper wrote: > On 20/12/2016 20:06, Doug Goldstein wrote: >> On 12/20/16 1:46 PM, Alistair Francis wrote: >>> Signed-off-by: Alistair Francis >>> --- >>> Config.mk | 2 +- >>> tools/blktap2/drivers/Makefile | 1 - >>>

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-20 Thread Alistair Francis
On Tue, Dec 20, 2016 at 12:16 PM, Andrew Cooper wrote: > On 20/12/2016 20:06, Doug Goldstein wrote: >> On 12/20/16 1:46 PM, Alistair Francis wrote: >>> Signed-off-by: Alistair Francis >>> --- >>> Config.mk | 2 +- >>>

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-20 Thread Andrew Cooper
On 20/12/2016 20:06, Doug Goldstein wrote: > On 12/20/16 1:46 PM, Alistair Francis wrote: >> Signed-off-by: Alistair Francis >> --- >> Config.mk | 2 +- >> tools/blktap2/drivers/Makefile | 1 - >> tools/libxl/Makefile | 2 +- >>

Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-20 Thread Doug Goldstein
On 12/20/16 1:46 PM, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > Config.mk | 2 +- > tools/blktap2/drivers/Makefile | 1 - > tools/libxl/Makefile | 2 +- > tools/xentrace/Makefile| 2 -- > 4 files changed,

[Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

2016-12-20 Thread Alistair Francis
Signed-off-by: Alistair Francis --- Config.mk | 2 +- tools/blktap2/drivers/Makefile | 1 - tools/libxl/Makefile | 2 +- tools/xentrace/Makefile| 2 -- 4 files changed, 2 insertions(+), 5 deletions(-) diff --git a/Config.mk