Re: [Xen-devel] [PATCH v2 2/2] x86: add a user configurable Kconfig option for the EHCI debug port

2016-09-20 Thread Jan Beulich
> On 19/09/2016 17:37, Derek Straka wrote: >> On Mon, Sep 19, 2016 at 10:56 AM, Julien Grall > > wrote: >> On 19/09/2016 16:51, Derek Straka wrote: >> >> Allows for the conditional inclusion of EHCI debug port driver >> on

Re: [Xen-devel] [PATCH v2 2/2] x86: add a user configurable Kconfig option for the EHCI debug port

2016-09-20 Thread Jan Beulich
>>> On 19.09.16 at 16:51, wrote: > --- a/xen/drivers/char/Kconfig > +++ b/xen/drivers/char/Kconfig > @@ -51,6 +51,11 @@ config HAS_SCIF > > config HAS_EHCI > bool > + > +config EHCI > + bool "EHCI debug port" if EXPERT = "y" > + default y > + depends on

Re: [Xen-devel] [PATCH v2 2/2] x86: add a user configurable Kconfig option for the EHCI debug port

2016-09-20 Thread Jan Beulich
>>> On 20.09.16 at 09:42, wrote: > Anyway, I am not the maintainers of this code. So I will let Andrew and > Jan deciding. I'm in general against needless moving around of code, but for the one line in question here I don't think it matters all that much where exactly it

Re: [Xen-devel] [PATCH v2 2/2] x86: add a user configurable Kconfig option for the EHCI debug port

2016-09-20 Thread Julien Grall
On 19/09/2016 17:37, Derek Straka wrote: Julien, On Mon, Sep 19, 2016 at 10:56 AM, Julien Grall > wrote: Hello, On 19/09/2016 16:51, Derek Straka wrote: Allows for the conditional inclusion of EHCI debug port driver

Re: [Xen-devel] [PATCH v2 2/2] x86: add a user configurable Kconfig option for the EHCI debug port

2016-09-19 Thread Derek Straka
Julien, On Mon, Sep 19, 2016 at 10:56 AM, Julien Grall wrote: > Hello, > > On 19/09/2016 16:51, Derek Straka wrote: > >> Allows for the conditional inclusion of EHCI debug port driver on the x86 >> platform rather than having it always enabled. >> >> The default

Re: [Xen-devel] [PATCH v2 2/2] x86: add a user configurable Kconfig option for the EHCI debug port

2016-09-19 Thread Julien Grall
Hello, On 19/09/2016 16:51, Derek Straka wrote: Allows for the conditional inclusion of EHCI debug port driver on the x86 platform rather than having it always enabled. The default configuration for the CONFIG_EHCI option remains 'y' on x86, so the behavior out of the box remains unchanged.

[Xen-devel] [PATCH v2 2/2] x86: add a user configurable Kconfig option for the EHCI debug port

2016-09-19 Thread Derek Straka
Allows for the conditional inclusion of EHCI debug port driver on the x86 platform rather than having it always enabled. The default configuration for the CONFIG_EHCI option remains 'y' on x86, so the behavior out of the box remains unchanged. The addition of the option allows advanced users to