Re: [Xen-devel] [PATCH v2 2/3] tools/libxc: add API for bitmap access for restore

2017-08-24 Thread Wei Liu
On Thu, Aug 24, 2017 at 08:36:16AM +0200, Olaf Hering wrote: > On Thu, Aug 17, Olaf Hering wrote: > > > Extend API for managing bitmaps. Each bitmap is now represented by a > > generic struct xc_sr_bitmap. > > > +static inline bool xc_sr_bitmap_resize(struct xc_sr_bitmap *bm, unsigned > > long b

Re: [Xen-devel] [PATCH v2 2/3] tools/libxc: add API for bitmap access for restore

2017-08-23 Thread Olaf Hering
On Thu, Aug 17, Olaf Hering wrote: > Extend API for managing bitmaps. Each bitmap is now represented by a > generic struct xc_sr_bitmap. > +static inline bool xc_sr_bitmap_resize(struct xc_sr_bitmap *bm, unsigned > long bits) > +static inline void xc_sr_bitmap_free(struct xc_sr_bitmap *bm) > +s

Re: [Xen-devel] [PATCH v2 2/3] tools/libxc: add API for bitmap access for restore

2017-08-22 Thread Wei Liu
On Tue, Aug 22, 2017 at 03:34:37PM +0100, Wei Liu wrote: > > +static inline int pfn_set_populated(struct xc_sr_context *ctx, xen_pfn_t > > pfn) > > +{ > > +xc_interface *xch = ctx->xch; > > + > > This is not used, right? Oh this is acutally used. Please ignore this comment.

Re: [Xen-devel] [PATCH v2 2/3] tools/libxc: add API for bitmap access for restore

2017-08-22 Thread Wei Liu
On Thu, Aug 17, 2017 at 07:01:32PM +0200, Olaf Hering wrote: > Extend API for managing bitmaps. Each bitmap is now represented by a > generic struct xc_sr_bitmap. > Switch the existing populated_pfns to this API. > > Signed-off-by: Olaf Hering > + [...] > +static inline void xc_sr_bitmap_free(str

[Xen-devel] [PATCH v2 2/3] tools/libxc: add API for bitmap access for restore

2017-08-17 Thread Olaf Hering
Extend API for managing bitmaps. Each bitmap is now represented by a generic struct xc_sr_bitmap. Switch the existing populated_pfns to this API. Signed-off-by: Olaf Hering --- tools/libxc/xc_sr_common.c | 41 +++ tools/libxc/xc_sr_common.h | 67