Re: [Xen-devel] [PATCH v2 2/5] compat: enforce distinguishable file names in symbol table

>>> On 03.11.15 at 13:22, wrote: > On Mon, 2015-11-02 at 09:11 -0700, Jan Beulich wrote: >> > Does all of that fall out from a desire to reuse __FILE__? If so I'm >> > inclined to suggest that -DBUILD_FILENAME_PREFIX="compat/" or whatever >> > would seem likely to me to

Re: [Xen-devel] [PATCH v2 2/5] compat: enforce distinguishable file names in symbol table

On Mon, 2015-11-02 at 09:11 -0700, Jan Beulich wrote: > > > >  > > It seems quite inconsistent to me to have xen/arch/x86/x86_64/Makefile > > building some files directly and xen/arch/x86/Makefile to be building > > another subset of those files via x86_64/FOO.o. Even more so that other > > than

Re: [Xen-devel] [PATCH v2 2/5] compat: enforce distinguishable file names in symbol table

>>> On 03.11.15 at 14:39, wrote: > On Tue, 2015-11-03 at 05:50 -0700, Jan Beulich wrote: >> That's certainly an option on x86 too, the more that the x86_64/ >> subtree is a remnant of x86_32 days only anyway. Just that doing >> this will mean quite a bit more work (not

Re: [Xen-devel] [PATCH v2 2/5] compat: enforce distinguishable file names in symbol table

On Tue, 2015-11-03 at 08:31 -0700, Jan Beulich wrote: > > > > On 03.11.15 at 14:39, wrote: > > On Tue, 2015-11-03 at 05:50 -0700, Jan Beulich wrote: > > > That's certainly an option on x86 too, the more that the x86_64/ > > > subtree is a remnant of x86_32 days only

Re: [Xen-devel] [PATCH v2 2/5] compat: enforce distinguishable file names in symbol table

On Tue, 2015-11-03 at 05:50 -0700, Jan Beulich wrote: > > > >  > > > Considering that Andrew was fine with the x86 parts, I'd want to > > > change the approach (the x86 side of which I understand is of > > > particular concern to you) only if you're convinced this alternative > > > approach is

Re: [Xen-devel] [PATCH v2 2/5] compat: enforce distinguishable file names in symbol table

On Mon, 2015-10-26 at 05:50 -0600, Jan Beulich wrote: > To make it possible to tell apart the static symbols in files built a > second for compat guest support, arrange for their source file names to ^ time ? > be prefixed by a suitable path. We can't do this without explicit .file >

Re: [Xen-devel] [PATCH v2 2/5] compat: enforce distinguishable file names in symbol table

>>> On 02.11.15 at 16:20, wrote: > On Mon, 2015-10-26 at 05:50 -0600, Jan Beulich wrote: >> To make it possible to tell apart the static symbols in files built a >> second for compat guest support, arrange for their source file names to > > ^ time ? Oh, yes, of

Re: [Xen-devel] [PATCH v2 2/5] compat: enforce distinguishable file names in symbol table

On 26/10/15 11:50, Jan Beulich wrote: > To make it possible to tell apart the static symbols in files built a > second for compat guest support, arrange for their source file names to > be prefixed by a suitable path. We can't do this without explicit .file > directives, since gcc has always been

[Xen-devel] [PATCH v2 2/5] compat: enforce distinguishable file names in symbol table

To make it possible to tell apart the static symbols in files built a second for compat guest support, arrange for their source file names to be prefixed by a suitable path. We can't do this without explicit .file directives, since gcc has always been stripping paths from file names handed to the