Re: [Xen-devel] [PATCH v2 2/5] libxl: enable per-VCPU extratime flag for RTDS

2017-10-09 Thread Meng Xu
On Tue, Sep 19, 2017 at 5:23 AM, Dario Faggioli wrote: > > On Fri, 2017-09-15 at 12:01 -0400, Meng Xu wrote: > > On Wed, Sep 13, 2017 at 8:16 PM, Dario Faggioli > > wrote: > > > > > > > I'm ok with what it is in this patch, although I feel

Re: [Xen-devel] [PATCH v2 2/5] libxl: enable per-VCPU extratime flag for RTDS

2017-09-19 Thread Dario Faggioli
On Fri, 2017-09-15 at 12:01 -0400, Meng Xu wrote: > On Wed, Sep 13, 2017 at 8:16 PM, Dario Faggioli > wrote: > > > > > I'm ok with what it is in this patch, although I feel that we can > > > kill the > > >  if (scinfo->extratime != > > >

Re: [Xen-devel] [PATCH v2 2/5] libxl: enable per-VCPU extratime flag for RTDS

2017-09-15 Thread Meng Xu
On Wed, Sep 13, 2017 at 8:16 PM, Dario Faggioli wrote: > On Fri, 2017-09-01 at 12:03 -0400, Meng Xu wrote: >> On Fri, Sep 1, 2017 at 11:58 AM, Meng Xu >> wrote: >> > @@ -705,6 +717,12 @@ static int sched_rtds_domain_set(libxl__gc >> > *gc,

Re: [Xen-devel] [PATCH v2 2/5] libxl: enable per-VCPU extratime flag for RTDS

2017-09-13 Thread Dario Faggioli
On Fri, 2017-09-01 at 12:03 -0400, Meng Xu wrote: > On Fri, Sep 1, 2017 at 11:58 AM, Meng Xu > wrote: > > @@ -705,6 +717,12 @@ static int sched_rtds_domain_set(libxl__gc > > *gc, uint32_t domid, > >  sdom.period = scinfo->period; > >  if (scinfo->budget !=

Re: [Xen-devel] [PATCH v2 2/5] libxl: enable per-VCPU extratime flag for RTDS

2017-09-13 Thread Dario Faggioli
On Fri, 2017-09-01 at 11:58 -0400, Meng Xu wrote: > Modify libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set > functions to support per-VCPU extratime flag > > Signed-off-by: Meng Xu > This patch looks ok to me. Only one thing: in libxl_types.idl is, when its

Re: [Xen-devel] [PATCH v2 2/5] libxl: enable per-VCPU extratime flag for RTDS

2017-09-01 Thread Meng Xu
Dario, I didn't include your Reviewed-by tag because I made one small change. On Fri, Sep 1, 2017 at 11:58 AM, Meng Xu wrote: > > Modify libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set > functions to support per-VCPU extratime flag > > Signed-off-by: Meng Xu

[Xen-devel] [PATCH v2 2/5] libxl: enable per-VCPU extratime flag for RTDS

2017-09-01 Thread Meng Xu
Modify libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set functions to support per-VCPU extratime flag Signed-off-by: Meng Xu --- Changes from v1 1) Add LIBXL_HAVE_SCHED_RTDS_VCPU_EXTRA to indicate if extratime flag is supported 2) Change flag name in domctl.h