Re: [Xen-devel] [PATCH v2 4/9] x86/pagewalk: Clean up guest_supports_* predicates

2017-03-24 Thread Jan Beulich
>>> On 23.03.17 at 18:32, wrote: > On 20/03/17 13:59, Jan Beulich wrote: > On 20.03.17 at 14:36, wrote: >>> On 20/03/17 08:45, Jan Beulich wrote: Also I'm still not really happy with the guest_supports_ prefixes for this and its

Re: [Xen-devel] [PATCH v2 4/9] x86/pagewalk: Clean up guest_supports_* predicates

2017-03-23 Thread Andrew Cooper
On 20/03/17 13:59, Jan Beulich wrote: On 20.03.17 at 14:36, wrote: >> On 20/03/17 08:45, Jan Beulich wrote: >>> Also I'm still not really happy with the guest_supports_ prefixes >>> for this and its L2 counterpart: The question here isn't whether the >>> guest

Re: [Xen-devel] [PATCH v2 4/9] x86/pagewalk: Clean up guest_supports_* predicates

2017-03-23 Thread Tim Deegan
At 16:31 + on 16 Mar (1489681898), Andrew Cooper wrote: > Switch them to returning bool, and taking const parameters. > > Rename guest_supports_superpages() to guest_supports_l2_superpages() to > indicate which level of pagetables it is actually referring to, and rename >

Re: [Xen-devel] [PATCH v2 4/9] x86/pagewalk: Clean up guest_supports_* predicates

2017-03-20 Thread Jan Beulich
>>> On 20.03.17 at 14:36, wrote: > On 20/03/17 08:45, Jan Beulich wrote: >> Also I'm still not really happy with the guest_supports_ prefixes >> for this and its L2 counterpart: The question here isn't whether the >> guest supports it (we can't know whether it does),

Re: [Xen-devel] [PATCH v2 4/9] x86/pagewalk: Clean up guest_supports_* predicates

2017-03-20 Thread Andrew Cooper
On 20/03/17 08:45, Jan Beulich wrote: On 16.03.17 at 17:31, wrote: >> Switch them to returning bool, and taking const parameters. >> >> Rename guest_supports_superpages() to guest_supports_l2_superpages() to >> indicate which level of pagetables it is actually

Re: [Xen-devel] [PATCH v2 4/9] x86/pagewalk: Clean up guest_supports_* predicates

2017-03-20 Thread Jan Beulich
>>> On 16.03.17 at 17:31, wrote: > Switch them to returning bool, and taking const parameters. > > Rename guest_supports_superpages() to guest_supports_l2_superpages() to > indicate which level of pagetables it is actually referring to, and rename >

[Xen-devel] [PATCH v2 4/9] x86/pagewalk: Clean up guest_supports_* predicates

2017-03-16 Thread Andrew Cooper
Switch them to returning bool, and taking const parameters. Rename guest_supports_superpages() to guest_supports_l2_superpages() to indicate which level of pagetables it is actually referring to, and rename guest_supports_1G_superpages() to guest_supports_l3_superpages() for consistency.