Re: [Xen-devel] [PATCH v2 5/9] x86/intel_pstate: relocate the driver register/unregister function

2015-05-29 Thread Jan Beulich
On 29.05.15 at 04:47, wei.w.w...@intel.com wrote: On 26/05/2015 21:06, Jan Beulich wrote On 13.05.16 at 09:50, wei.w.w...@intel.com wrote: Register/unregister the CPU hotplug notifier when the driver is registered, and move the driver register/unregister function to the cpufreq.c.

Re: [Xen-devel] [PATCH v2 5/9] x86/intel_pstate: relocate the driver register/unregister function

2015-05-28 Thread Wang, Wei W
On 26/05/2015 21:17, Jan Beulich wrote On 13.05.16 at 09:50, wei.w.w...@intel.com wrote: +extern int cpufreq_register_driver(struct cpufreq_driver +*driver_data); extern int cpufreq_unregister_driver(struct +cpufreq_driver *driver); Oh, btw, please also get rid of extern on function

Re: [Xen-devel] [PATCH v2 5/9] x86/intel_pstate: relocate the driver register/unregister function

2015-05-28 Thread Wang, Wei W
On 26/05/2015 21:06, Jan Beulich wrote On 13.05.16 at 09:50, wei.w.w...@intel.com wrote: Register/unregister the CPU hotplug notifier when the driver is registered, and move the driver register/unregister function to the cpufreq.c. Without saying why I'm afraid I don't even see much

Re: [Xen-devel] [PATCH v2 5/9] x86/intel_pstate: relocate the driver register/unregister function

2015-05-26 Thread Jan Beulich
On 13.05.16 at 09:50, wei.w.w...@intel.com wrote: Register/unregister the CPU hotplug notifier when the driver is registered, and move the driver register/unregister function to the cpufreq.c. Without saying why I'm afraid I don't even see much reason to review this in any detail. ---

Re: [Xen-devel] [PATCH v2 5/9] x86/intel_pstate: relocate the driver register/unregister function

2015-05-26 Thread Jan Beulich
On 13.05.16 at 09:50, wei.w.w...@intel.com wrote: +extern int cpufreq_register_driver(struct cpufreq_driver *driver_data); +extern int cpufreq_unregister_driver(struct cpufreq_driver *driver); Oh, btw, please also get rid of extern on function declarations, unless in a particular header it is

[Xen-devel] [PATCH v2 5/9] x86/intel_pstate: relocate the driver register/unregister function

2015-05-13 Thread Wei Wang
Register/unregister the CPU hotplug notifier when the driver is registered, and move the driver register/unregister function to the cpufreq.c. Signed-off-by: Wei Wang wei.w.w...@intel.com --- xen/drivers/cpufreq/cpufreq.c | 27 +++ xen/include/acpi/cpufreq/cpufreq.h