Re: [Xen-devel] [PATCH v2 for-4.9] x86/mm: Fix incorrect unmapping of 2MB and 1GB pages

2017-05-23 Thread Andrew Cooper
On 24/05/2017 07:20, Jan Beulich wrote: > I'm kind of disappointed that there was no visible attempt > from Igor so far to help the situation. Igor is out of the office at the moment, and besides, this thread of problem is only 36h old at this point, which is a single working day in this timezone.

Re: [Xen-devel] [PATCH v2 for-4.9] x86/mm: Fix incorrect unmapping of 2MB and 1GB pages

2017-05-23 Thread Jan Beulich
>>> On 24.05.17 at 00:25, wrote: > On 05/23/2017 10:32 AM, Boris Ostrovsky wrote: >> On 05/23/2017 10:05 AM, Jan Beulich wrote: >>> Further changes may then >>> be needed to the splitting of large pages (in p2m_next_level()) >>> depending on whether INVALID_MFN entries can make it there. >> Let me

Re: [Xen-devel] [PATCH v2 for-4.9] x86/mm: Fix incorrect unmapping of 2MB and 1GB pages

2017-05-23 Thread Boris Ostrovsky
On 05/23/2017 10:32 AM, Boris Ostrovsky wrote: > On 05/23/2017 10:05 AM, Jan Beulich wrote: > On 23.05.17 at 15:40, wrote: >>> And you haven't been able to reproduce this? I see this fail on two AMD >>> systems (different processor families). >> I didn't even have the time to try. >> >>> And t

Re: [Xen-devel] [PATCH v2 for-4.9] x86/mm: Fix incorrect unmapping of 2MB and 1GB pages

2017-05-23 Thread Boris Ostrovsky
On 05/23/2017 10:05 AM, Jan Beulich wrote: On 23.05.17 at 15:40, wrote: >> And you haven't been able to reproduce this? I see this fail on two AMD >> systems (different processor families). > I didn't even have the time to try. > >> And this: >> >> --- a/xen/arch/x86/mm/p2m.c >> +++ b/xen/arc

Re: [Xen-devel] [PATCH v2 for-4.9] x86/mm: Fix incorrect unmapping of 2MB and 1GB pages

2017-05-23 Thread Jan Beulich
>>> On 23.05.17 at 15:40, wrote: > And you haven't been able to reproduce this? I see this fail on two AMD > systems (different processor families). I didn't even have the time to try. > And this: > > --- a/xen/arch/x86/mm/p2m.c > +++ b/xen/arch/x86/mm/p2m.c > @@ -560,7 +560,7 @@ int p2m_set_en

Re: [Xen-devel] [PATCH v2 for-4.9] x86/mm: Fix incorrect unmapping of 2MB and 1GB pages

2017-05-23 Thread Boris Ostrovsky
On 05/23/2017 09:17 AM, Jan Beulich wrote: On 23.05.17 at 15:00, wrote: >> (d1) Testing HVM environment: >> (XEN) d1v0 Triple fault - invoking HVM shutdown action 1 >> (XEN) *** Dumping Dom1 vcpu#0 state: *** >> (XEN) [ Xen-4.9-rc x86_64 debug=y Tainted: C ] >> (XEN) CPU:11

Re: [Xen-devel] [PATCH v2 for-4.9] x86/mm: Fix incorrect unmapping of 2MB and 1GB pages

2017-05-23 Thread Jan Beulich
>>> On 23.05.17 at 15:00, wrote: > (d1) Testing HVM environment: > (XEN) d1v0 Triple fault - invoking HVM shutdown action 1 > (XEN) *** Dumping Dom1 vcpu#0 state: *** > (XEN) [ Xen-4.9-rc x86_64 debug=y Tainted: C ] > (XEN) CPU:11 > (XEN) RIP:0018:[<0010815c>] > (XEN

Re: [Xen-devel] [PATCH v2 for-4.9] x86/mm: Fix incorrect unmapping of 2MB and 1GB pages

2017-05-23 Thread Boris Ostrovsky
On 05/23/2017 04:07 AM, Jan Beulich wrote: On 22.05.17 at 20:01, wrote: >> On 05/10/2017 07:13 AM, Igor Druzhinin wrote: >>> The same set of functions is used to set as well as to clean >>> P2M entries, except that for clean operations INVALID_MFN (~0UL) >>> is passed as a parameter. Unfortun

Re: [Xen-devel] [PATCH v2 for-4.9] x86/mm: Fix incorrect unmapping of 2MB and 1GB pages

2017-05-23 Thread Jan Beulich
>>> On 22.05.17 at 20:01, wrote: > On 05/10/2017 07:13 AM, Igor Druzhinin wrote: >> The same set of functions is used to set as well as to clean >> P2M entries, except that for clean operations INVALID_MFN (~0UL) >> is passed as a parameter. Unfortunately, when calculating an >> appropriate target

Re: [Xen-devel] [PATCH v2 for-4.9] x86/mm: Fix incorrect unmapping of 2MB and 1GB pages

2017-05-22 Thread Boris Ostrovsky
On 05/10/2017 07:13 AM, Igor Druzhinin wrote: > The same set of functions is used to set as well as to clean > P2M entries, except that for clean operations INVALID_MFN (~0UL) > is passed as a parameter. Unfortunately, when calculating an > appropriate target order for a particular mapping INVALID_

Re: [Xen-devel] [PATCH v2 for-4.9] x86/mm: Fix incorrect unmapping of 2MB and 1GB pages

2017-05-17 Thread Julien Grall
Hello, Sorry I missed that patch. In the future, please CC me if you want a patch to go in Xen 4.9. On 10/05/17 12:13, Igor Druzhinin wrote: The same set of functions is used to set as well as to clean P2M entries, except that for clean operations INVALID_MFN (~0UL) is passed as a parameter.

Re: [Xen-devel] [PATCH v2 for-4.9] x86/mm: Fix incorrect unmapping of 2MB and 1GB pages

2017-05-15 Thread George Dunlap
On Wed, May 10, 2017 at 12:13 PM, Igor Druzhinin wrote: > The same set of functions is used to set as well as to clean > P2M entries, except that for clean operations INVALID_MFN (~0UL) > is passed as a parameter. Unfortunately, when calculating an > appropriate target order for a particular mappi

Re: [Xen-devel] [PATCH v2 for-4.9] x86/mm: Fix incorrect unmapping of 2MB and 1GB pages

2017-05-14 Thread Tian, Kevin
> From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] > Sent: Wednesday, May 10, 2017 7:13 PM > > The same set of functions is used to set as well as to clean > P2M entries, except that for clean operations INVALID_MFN (~0UL) > is passed as a parameter. Unfortunately, when calculating an > app

Re: [Xen-devel] [PATCH v2 for-4.9] x86/mm: Fix incorrect unmapping of 2MB and 1GB pages

2017-05-10 Thread Jan Beulich
>>> On 10.05.17 at 13:13, wrote: > The same set of functions is used to set as well as to clean > P2M entries, except that for clean operations INVALID_MFN (~0UL) > is passed as a parameter. Unfortunately, when calculating an > appropriate target order for a particular mapping INVALID_MFN > is not

[Xen-devel] [PATCH v2 for-4.9] x86/mm: Fix incorrect unmapping of 2MB and 1GB pages

2017-05-10 Thread Igor Druzhinin
The same set of functions is used to set as well as to clean P2M entries, except that for clean operations INVALID_MFN (~0UL) is passed as a parameter. Unfortunately, when calculating an appropriate target order for a particular mapping INVALID_MFN is not taken into account which leads to 4K page t