Re: [Xen-devel] [PATCH v2 for-4.9] x86/pagewalk: Fix determination of Protection Key access rights

2017-05-19 Thread Julien Grall
Hi Andrew, On 18/05/17 16:02, Andrew Cooper wrote: On 18/05/17 15:31, Tim Deegan wrote: Hi, At 15:02 +0100 on 18 May (1495119734), Andrew Cooper wrote: * When fabricating gl1e's from superpages, propagate the protection key as well, so the protection key logic sees the real key as

Re: [Xen-devel] [PATCH v2 for-4.9] x86/pagewalk: Fix determination of Protection Key access rights

2017-05-18 Thread Andrew Cooper
On 18/05/17 15:31, Tim Deegan wrote: > Hi, > > At 15:02 +0100 on 18 May (1495119734), Andrew Cooper wrote: >> * When fabricating gl1e's from superpages, propagate the protection key as >>well, so the protection key logic sees the real key as opposed to 0. >> >> * Experimentally, the

Re: [Xen-devel] [PATCH v2 for-4.9] x86/pagewalk: Fix determination of Protection Key access rights

2017-05-18 Thread Tim Deegan
Hi, At 15:02 +0100 on 18 May (1495119734), Andrew Cooper wrote: > * When fabricating gl1e's from superpages, propagate the protection key as >well, so the protection key logic sees the real key as opposed to 0. > > * Experimentally, the protection key checks are performed ahead of the

[Xen-devel] [PATCH v2 for-4.9] x86/pagewalk: Fix determination of Protection Key access rights

2017-05-18 Thread Andrew Cooper
* When fabricating gl1e's from superpages, propagate the protection key as well, so the protection key logic sees the real key as opposed to 0. * Experimentally, the protection key checks are performed ahead of the other access rights. In particular, accesses which fail both protection