Re: [Xen-devel] [PATCH v3 06/23] xsplice: Implement payload loading (v4)

2016-02-19 Thread Konrad Rzeszutek Wilk
> > + hdr->e_ident[EI_CLASS] != ELFCLASS64 || > > + hdr->e_ident[EI_DATA] != ELFDATA2LSB || > > + hdr->e_ident[EI_OSABI] != ELFOSABI_SYSV || > > + hdr->e_machine != EM_X86_64 || > > + hdr->e_type != ET_REL || > > + hdr->e_phnum != 0 ) > > +{ > > +

Re: [Xen-devel] [PATCH v3 06/23] xsplice: Implement payload loading (v4)

2016-02-12 Thread Andrew Cooper
On 12/02/16 18:05, Konrad Rzeszutek Wilk wrote: I will refrain from repeating the same review from previous patches. > +int xsplice_verify_elf(struct xsplice_elf *elf, uint8_t *data) > +{ > + > +Elf_Ehdr *hdr = (Elf_Ehdr *)data; > + > +if ( elf->len < (sizeof *hdr) || > + !IS_ELF(

[Xen-devel] [PATCH v3 06/23] xsplice: Implement payload loading (v4)

2016-02-12 Thread Konrad Rzeszutek Wilk
From: Ross Lagerwall Add support for loading xsplice payloads. This is somewhat similar to the Linux kernel module loader, implementing the following steps: - Verify the elf file. - Parse the elf file. - Allocate a region of memory mapped within a free area of [xen_virt_end, XEN_VIRT_END]. - Co