On Mon, Nov 17, 2014 at 10:55:34AM +, Li, Liang Z wrote:
> > > The libxl__device_exists will return 1 if more than one PCI devices are
> > > attached to the guest, no matter the BDFs are identical or not.
> >
> > That means this check is problematic. I think the original intention was to
> >
> > The libxl__device_exists will return 1 if more than one PCI devices are
> > attached to the guest, no matter the BDFs are identical or not.
>
> That means this check is problematic. I think the original intention was to
> check on BDFs, however it wasn't thoroughly tested. Sorry.
>
> > I don'
On Mon, Nov 17, 2014 at 07:53:44AM +, Li, Liang Z wrote:
> > Originally the code allowed users to attach the same device more than
> > once. It just stupidly overwrites xenstore entries. This is bogus as
> > frontend will be very confused.
> >
> > Introduce a helper function to check if the dev
> Originally the code allowed users to attach the same device more than
> once. It just stupidly overwrites xenstore entries. This is bogus as
> frontend will be very confused.
>
> Introduce a helper function to check if the device to be written to
> xenstore already exists. A new error code is als