Re: [Xen-devel] [PATCH v3 2/3] IB/qib: use arch_phys_wc_add()

2015-04-21 Thread Marciniszyn, Mike
> > This driver already makes use of ioremap_wc() on PIO buffers, so > > convert it to use arch_phys_wc_add(). > > This is probably OK, but I think you should also remove the qib_wc_pat module > parameter. > > Jason Revise based on Jason's request and I will do some testing. Mike _

Re: [Xen-devel] [PATCH v3 2/3] IB/qib: use arch_phys_wc_add()

2015-04-21 Thread Jason Gunthorpe
On Tue, Apr 21, 2015 at 01:37:55PM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > This driver already makes use of ioremap_wc() on PIO buffers, > so convert it to use arch_phys_wc_add(). This is probably OK, but I think you should also remove the qib_wc_pat module parameter. Ja

Re: [Xen-devel] [PATCH v3 2/3] IB/qib: use arch_phys_wc_add()

2015-04-21 Thread Luis R. Rodriguez
On Tue, Apr 21, 2015 at 2:12 PM, Andy Lutomirski wrote: > On Tue, Apr 21, 2015 at 2:09 PM, Luis R. Rodriguez > wrote: >> On Tue, Apr 21, 2015 at 1:59 PM, Marciniszyn, Mike >> wrote: > This driver already makes use of ioremap_wc() on PIO buffers, so > convert it to use arch_phys_wc_add(

Re: [Xen-devel] [PATCH v3 2/3] IB/qib: use arch_phys_wc_add()

2015-04-21 Thread Andy Lutomirski
On Tue, Apr 21, 2015 at 2:09 PM, Luis R. Rodriguez wrote: > On Tue, Apr 21, 2015 at 1:59 PM, Marciniszyn, Mike > wrote: >>> > This driver already makes use of ioremap_wc() on PIO buffers, so >>> > convert it to use arch_phys_wc_add(). >>> >>> This is probably OK, but I think you should also remov

Re: [Xen-devel] [PATCH v3 2/3] IB/qib: use arch_phys_wc_add()

2015-04-21 Thread Luis R. Rodriguez
On Tue, Apr 21, 2015 at 1:59 PM, Marciniszyn, Mike wrote: >> > This driver already makes use of ioremap_wc() on PIO buffers, so >> > convert it to use arch_phys_wc_add(). >> >> This is probably OK, but I think you should also remove the qib_wc_pat module >> parameter. >> >> Jason > > Revise based

[Xen-devel] [PATCH v3 2/3] IB/qib: use arch_phys_wc_add()

2015-04-21 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This driver already makes use of ioremap_wc() on PIO buffers, so convert it to use arch_phys_wc_add(). Cc: Toshi Kani Cc: Rickard Strandqvist Cc: Mike Marciniszyn Cc: Roland Dreier Cc: Sean Hefty Cc: Hal Rosenstock Cc: Dennis Dalessandro Cc: Andy Lutomirski Cc: