Re: [Xen-devel] [PATCH v3 2/4] xen/save: allow the usage of zeroextend and a fixup function

2015-11-20 Thread Jan Beulich
>>> On 18.11.15 at 17:37, wrote: > +if ( HVM_SAVE_HAS_COMPAT(_x) && d->length != HVM_SAVE_LENGTH(_x) ) \ If you broke this line at the && you could avoid all the churn to move out the \ by a few spaces. That would also have avoided Andrew's request for re-assurance that the addition here

Re: [Xen-devel] [PATCH v3 2/4] xen/save: allow the usage of zeroextend and a fixup function

2015-11-20 Thread Andrew Cooper
On 18/11/15 16:37, Roger Pau Monne wrote: > With the current compat implementation in the save/restore context handling, > only one compat structure is allowed, and using _zeroextend prevents the > fixup function from being called. > > In order to allow for the compat handling layer to be able to h

[Xen-devel] [PATCH v3 2/4] xen/save: allow the usage of zeroextend and a fixup function

2015-11-18 Thread Roger Pau Monne
With the current compat implementation in the save/restore context handling, only one compat structure is allowed, and using _zeroextend prevents the fixup function from being called. In order to allow for the compat handling layer to be able to handle different compat versions allow calling the f