Re: [Xen-devel] [PATCH v3 2/6] libxl: Fix libxl_set_memory_target return value

2015-12-08 Thread George Dunlap
On 08/12/15 17:19, Ian Campbell wrote: > On Tue, 2015-12-01 at 11:53 +, George Dunlap wrote: >> libxl_set_memory_target seems to have the following return values: >> >> * 1 on failure, if the failure happens because of a xenstore error *or* >> invalid target >> >> * -1 if the setmaxmem hypercal

Re: [Xen-devel] [PATCH v3 2/6] libxl: Fix libxl_set_memory_target return value

2015-12-08 Thread Ian Campbell
On Tue, 2015-12-01 at 11:53 +, George Dunlap wrote: > libxl_set_memory_target seems to have the following return values: > > * 1 on failure, if the failure happens because of a xenstore error *or* > invalid target > > * -1 if the setmaxmem hypercall > > * -errno if the set_pod_target hyperca

[Xen-devel] [PATCH v3 2/6] libxl: Fix libxl_set_memory_target return value

2015-12-01 Thread George Dunlap
libxl_set_memory_target seems to have the following return values: * 1 on failure, if the failure happens because of a xenstore error *or* invalid target * -1 if the setmaxmem hypercall * -errno if the set_pod_target hypercall target fails * 1 on success (!) Make it consistenstly return ERROR