Re: [Xen-devel] [PATCH v3 3/3] x86/string: Clean up x86/string.h

2017-05-31 Thread Jan Beulich
>>> On 31.05.17 at 14:42, wrote: > On 15/05/17 15:22, Jan Beulich wrote: > On 15.05.17 at 15:08, wrote: >>> On 15/05/17 11:19, Jan Beulich wrote: >>> On 15.05.17 at 12:08, wrote: On 12.05.17 at 19:35, wrote: >> --- a/xen/include/asm-x86/string.h >> +++ b/xen/include/a

Re: [Xen-devel] [PATCH v3 3/3] x86/string: Clean up x86/string.h

2017-05-31 Thread Andrew Cooper
On 15/05/17 15:22, Jan Beulich wrote: On 15.05.17 at 15:08, wrote: >> On 15/05/17 11:19, Jan Beulich wrote: >>> >>> On 15.05.17 at 12:08, wrote: >>> On 12.05.17 at 19:35, wrote: > --- a/xen/include/asm-x86/string.h > +++ b/xen/include/asm-x86/string.h > @@ -2,13 +2,23 @@ >>

Re: [Xen-devel] [PATCH v3 3/3] x86/string: Clean up x86/string.h

2017-05-15 Thread Jan Beulich
>>> On 15.05.17 at 15:08, wrote: > On 15/05/17 11:19, Jan Beulich wrote: >> >>> On 15.05.17 at 12:08, wrote: >> On 12.05.17 at 19:35, wrote: --- a/xen/include/asm-x86/string.h +++ b/xen/include/asm-x86/string.h @@ -2,13 +2,23 @@ #define __X86_STRING_H__ #de

Re: [Xen-devel] [PATCH v3 3/3] x86/string: Clean up x86/string.h

2017-05-15 Thread Andrew Cooper
On 15/05/17 11:19, Jan Beulich wrote: > >>> On 15.05.17 at 12:08, wrote: > On 12.05.17 at 19:35, wrote: >>> --- a/xen/include/asm-x86/string.h >>> +++ b/xen/include/asm-x86/string.h >>> @@ -2,13 +2,23 @@ >>> #define __X86_STRING_H__ >>> >>> #define __HAVE_ARCH_MEMCPY >>> -#define memcpy(

Re: [Xen-devel] [PATCH v3 3/3] x86/string: Clean up x86/string.h

2017-05-15 Thread Jan Beulich
>>> On 15.05.17 at 12:08, wrote: On 12.05.17 at 19:35, wrote: >> --- a/xen/include/asm-x86/string.h >> +++ b/xen/include/asm-x86/string.h >> @@ -2,13 +2,23 @@ >> #define __X86_STRING_H__ >> >> #define __HAVE_ARCH_MEMCPY >> -#define memcpy(t,f,n) (__builtin_memcpy((t),(f),(n))) >> +void

Re: [Xen-devel] [PATCH v3 3/3] x86/string: Clean up x86/string.h

2017-05-15 Thread Jan Beulich
>>> On 12.05.17 at 19:35, wrote: > --- a/xen/include/asm-x86/string.h > +++ b/xen/include/asm-x86/string.h > @@ -2,13 +2,23 @@ > #define __X86_STRING_H__ > > #define __HAVE_ARCH_MEMCPY > -#define memcpy(t,f,n) (__builtin_memcpy((t),(f),(n))) > +void *memcpy(void *dest, const void *src, size_t

[Xen-devel] [PATCH v3 3/3] x86/string: Clean up x86/string.h

2017-05-12 Thread Andrew Cooper
* None of the GCC docs mention memmove() in its list of builtins even today, but 4.1 does have the builtin, meaning that all currently supported compilers have it. * Consistently use Xen style, matching the common code, and introduce symbol definitions for function pointer use. No funct