Re: [Xen-devel] [PATCH v3 3/9] version/livepatch: Move xen_build_id_check to version.h

2016-08-19 Thread Ross Lagerwall
On 08/14/2016 10:52 PM, Konrad Rzeszutek Wilk wrote: It makes more sense for it to be there. However that means the version.h has now a dependency on as the Elf_Note is a macro. The elfstructs.h has a dependency on types.h as well so we need that. We cannot put that #include in elfstructs.h as

Re: [Xen-devel] [PATCH v3 3/9] version/livepatch: Move xen_build_id_check to version.h

2016-08-15 Thread Jan Beulich
>>> On 14.08.16 at 23:52, wrote: > It makes more sense for it to be there. However that > means the version.h has now a dependency on > as the Elf_Note is a macro. > > The elfstructs.h has a dependency on types.h as well so > we need that. We cannot put that #include > in elfstructs.h as that f

[Xen-devel] [PATCH v3 3/9] version/livepatch: Move xen_build_id_check to version.h

2016-08-14 Thread Konrad Rzeszutek Wilk
It makes more sense for it to be there. However that means the version.h has now a dependency on as the Elf_Note is a macro. The elfstructs.h has a dependency on types.h as well so we need that. We cannot put that #include in elfstructs.h as that file is used by tools and they do not have such f