Re: [Xen-devel] [PATCH v3 5/5] fix: add multiboot2 protocol support for EFI platforms

2017-01-18 Thread Doug Goldstein
On 1/18/17 8:41 AM, Jan Beulich wrote: On 18.01.17 at 14:33, wrote: >> On 1/18/17 4:52 AM, Jan Beulich wrote: >> On 17.01.17 at 21:07, wrote: @@ -686,6 +683,10 @@ paddr_t __init efi_multiboot2(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTa setup_efi_pci();

Re: [Xen-devel] [PATCH v3 5/5] fix: add multiboot2 protocol support for EFI platforms

2017-01-18 Thread Jan Beulich
>>> On 18.01.17 at 14:33, wrote: > On 1/18/17 4:52 AM, Jan Beulich wrote: > On 17.01.17 at 21:07, wrote: >>> --- a/xen/arch/x86/boot/head.S >>> +++ b/xen/arch/x86/boot/head.S >>> @@ -519,6 +519,7 @@ trampoline_setup: >>> 1: >>> /* Switch to low-memory stack. */ >>> mov

Re: [Xen-devel] [PATCH v3 5/5] fix: add multiboot2 protocol support for EFI platforms

2017-01-18 Thread Doug Goldstein
On 1/18/17 4:52 AM, Jan Beulich wrote: On 17.01.17 at 21:07, wrote: >> --- a/xen/arch/x86/boot/head.S >> +++ b/xen/arch/x86/boot/head.S >> @@ -519,6 +519,7 @@ trampoline_setup: >> 1: >> /* Switch to low-memory stack. */ >> mov sym_phys(trampoline_phys),%edi >> +

Re: [Xen-devel] [PATCH v3 5/5] fix: add multiboot2 protocol support for EFI platforms

2017-01-18 Thread Jan Beulich
>>> On 17.01.17 at 21:07, wrote: > --- a/xen/arch/x86/boot/head.S > +++ b/xen/arch/x86/boot/head.S > @@ -519,6 +519,7 @@ trampoline_setup: > 1: > /* Switch to low-memory stack. */ > mov sym_phys(trampoline_phys),%edi > +/* The stack base is 64kb after the location o

[Xen-devel] [PATCH v3 5/5] fix: add multiboot2 protocol support for EFI platforms

2017-01-17 Thread Doug Goldstein
This should be squashed into the 4/4 patch 'x86: add multiboot2 protocol support for EFI platforms'. - fix incorrect assembly (identified by Andrew Cooper) - fix issue where the trampoline size was left as 0 and the way the memory is allocated for the trampolines we would go to the end of an a