Re: [Xen-devel] [PATCH v4 01/34] compat/x86: Remove unncessary #define.

2016-03-19 Thread Konrad Rzeszutek Wilk
On Wed, Mar 16, 2016 at 05:08:30AM -0600, Jan Beulich wrote: > >>> On 15.03.16 at 18:56, wrote: > > It is not used. > > Consistently please - either keep them all (just to cover the case > that they might get used) or remove them all: xen_compile_info, >

Re: [Xen-devel] [PATCH v4 01/34] compat/x86: Remove unncessary #define.

2016-03-19 Thread Jan Beulich
>>> On 17.03.16 at 01:44, wrote: > On Wed, Mar 16, 2016 at 05:08:30AM -0600, Jan Beulich wrote: >> >>> On 15.03.16 at 18:56, wrote: >> > It is not used. >> >> Consistently please - either keep them all (just to cover the case >> that they might get

Re: [Xen-devel] [PATCH v4 01/34] compat/x86: Remove unncessary #define.

2016-03-16 Thread Jan Beulich
>>> On 15.03.16 at 18:56, wrote: > It is not used. Consistently please - either keep them all (just to cover the case that they might get used) or remove them all: xen_compile_info, xen_changeset_info, etc are all unused too. Otoh xennmi_callback is used, but

Re: [Xen-devel] [PATCH v4 01/34] compat/x86: Remove unncessary #define.

2016-03-15 Thread Andrew Cooper
On 15/03/16 17:56, Konrad Rzeszutek Wilk wrote: > It is not used. > > Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xen.org

[Xen-devel] [PATCH v4 01/34] compat/x86: Remove unncessary #define.

2016-03-15 Thread Konrad Rzeszutek Wilk
It is not used. Signed-off-by: Konrad Rzeszutek Wilk --- Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- --- xen/common/compat/kernel.c | 1 - 1 file changed, 1 deletion(-)