Re: [Xen-devel] [PATCH v4 07/16] livepatch/arm/x86: Check payload for for unwelcomed symbols.

2016-09-20 Thread Julien Grall
Hi Konrad, On 19/09/2016 19:32, Konrad Rzeszutek Wilk wrote: On Mon, Sep 19, 2016 at 08:48:10AM -0600, Jan Beulich wrote: On 19.09.16 at 16:13, wrote: On 19/09/2016 16:11, Jan Beulich wrote: On 19.09.16 at 15:33, wrote: On 19/09/2016 11:27,

Re: [Xen-devel] [PATCH v4 07/16] livepatch/arm/x86: Check payload for for unwelcomed symbols.

2016-09-20 Thread Jan Beulich
>>> On 19.09.16 at 19:32, wrote: > On Mon, Sep 19, 2016 at 08:48:10AM -0600, Jan Beulich wrote: >> >>> On 19.09.16 at 16:13, wrote: >> >> > >> > On 19/09/2016 16:11, Jan Beulich wrote: >> > On 19.09.16 at 15:33, wrote: >>

Re: [Xen-devel] [PATCH v4 07/16] livepatch/arm/x86: Check payload for for unwelcomed symbols.

2016-09-19 Thread Konrad Rzeszutek Wilk
On Mon, Sep 19, 2016 at 08:48:10AM -0600, Jan Beulich wrote: > >>> On 19.09.16 at 16:13, wrote: > > > > > On 19/09/2016 16:11, Jan Beulich wrote: > > On 19.09.16 at 15:33, wrote: > >>> On 19/09/2016 11:27, Jan Beulich wrote: > >>> On 16.09.16

Re: [Xen-devel] [PATCH v4 07/16] livepatch/arm/x86: Check payload for for unwelcomed symbols.

2016-09-19 Thread Jan Beulich
>>> On 19.09.16 at 16:13, wrote: > > On 19/09/2016 16:11, Jan Beulich wrote: > On 19.09.16 at 15:33, wrote: >>> On 19/09/2016 11:27, Jan Beulich wrote: >>> On 16.09.16 at 18:38, wrote: > ---

Re: [Xen-devel] [PATCH v4 07/16] livepatch/arm/x86: Check payload for for unwelcomed symbols.

2016-09-19 Thread Julien Grall
On 19/09/2016 16:11, Jan Beulich wrote: On 19.09.16 at 15:33, wrote: On 19/09/2016 11:27, Jan Beulich wrote: On 16.09.16 at 18:38, wrote: --- a/xen/arch/arm/livepatch.c +++ b/xen/arch/arm/livepatch.c @@ -117,6 +117,20 @@ bool

Re: [Xen-devel] [PATCH v4 07/16] livepatch/arm/x86: Check payload for for unwelcomed symbols.

2016-09-19 Thread Jan Beulich
>>> On 19.09.16 at 15:33, wrote: > Hi, > > On 19/09/2016 11:27, Jan Beulich wrote: > On 16.09.16 at 18:38, wrote: >>> --- a/xen/arch/arm/livepatch.c >>> +++ b/xen/arch/arm/livepatch.c >>> @@ -117,6 +117,20 @@ bool arch_livepatch_symbol_ok(const

Re: [Xen-devel] [PATCH v4 07/16] livepatch/arm/x86: Check payload for for unwelcomed symbols.

2016-09-19 Thread Julien Grall
Hi, On 19/09/2016 11:27, Jan Beulich wrote: On 16.09.16 at 18:38, wrote: --- a/xen/arch/arm/livepatch.c +++ b/xen/arch/arm/livepatch.c @@ -117,6 +117,20 @@ bool arch_livepatch_symbol_ok(const struct livepatch_elf *elf, return true; } +bool

Re: [Xen-devel] [PATCH v4 07/16] livepatch/arm/x86: Check payload for for unwelcomed symbols.

2016-09-19 Thread Jan Beulich
>>> On 16.09.16 at 18:38, wrote: > --- a/xen/arch/arm/livepatch.c > +++ b/xen/arch/arm/livepatch.c > @@ -117,6 +117,20 @@ bool arch_livepatch_symbol_ok(const struct livepatch_elf > *elf, > return true; > } > > +bool arch_livepatch_symbol_deny(const struct

[Xen-devel] [PATCH v4 07/16] livepatch/arm/x86: Check payload for for unwelcomed symbols.

2016-09-16 Thread Konrad Rzeszutek Wilk
Certain platforms, such as ARM [32|64] add extra mapping symbols such as $x (for ARM64 instructions), or more interesting to this patch: $t (for Thumb instructions). These symbols are suppose to help the final linker to make any adjustments (such as add an veneer). But more importantly - we do not