Re: [Xen-devel] [PATCH v4 1/6] libelf: rewrite symtab/strtab loading for Dom0

2016-01-22 Thread Roger Pau Monné
El 22/01/16 a les 9.11, Jan Beulich ha escrit: On 21.01.16 at 18:55, wrote: >> El 21/01/16 a les 18.29, Ian Jackson ha escrit: >>> Roger Pau Monne writes ("[PATCH v4 1/6] libelf: rewrite symtab/strtab >> loading for Dom0"): Current implementation of

Re: [Xen-devel] [PATCH v4 1/6] libelf: rewrite symtab/strtab loading for Dom0

2016-01-22 Thread Jan Beulich
>>> On 21.01.16 at 18:55, wrote: > El 21/01/16 a les 18.29, Ian Jackson ha escrit: >> Roger Pau Monne writes ("[PATCH v4 1/6] libelf: rewrite symtab/strtab > loading for Dom0"): >>> Current implementation of elf_load_bsdsyms is broken when loading inside of >>> a HVM guest,

Re: [Xen-devel] [PATCH v4 1/6] libelf: rewrite symtab/strtab loading for Dom0

2016-01-21 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v4 1/6] libelf: rewrite symtab/strtab loading for Dom0"): > Current implementation of elf_load_bsdsyms is broken when loading inside of > a HVM guest, because it assumes elf_memcpy_safe is able to write into guest > memory space, which it is not. > > Take the

Re: [Xen-devel] [PATCH v4 1/6] libelf: rewrite symtab/strtab loading for Dom0

2016-01-21 Thread Ian Jackson
Roger Pau Monné writes ("Re: [PATCH v4 1/6] libelf: rewrite symtab/strtab loading for Dom0"): > El 21/01/16 a les 18.29, Ian Jackson ha escrit: > > Roger Pau Monne writes ("[PATCH v4 1/6] libelf: rewrite symtab/strtab > > loading for Dom0"): > >> #define elf_hdr_elm(_elf, _hdr, _elm, _val)

Re: [Xen-devel] [PATCH v4 1/6] libelf: rewrite symtab/strtab loading for Dom0

2016-01-21 Thread Roger Pau Monné
El 21/01/16 a les 18.29, Ian Jackson ha escrit: > Roger Pau Monne writes ("[PATCH v4 1/6] libelf: rewrite symtab/strtab loading > for Dom0"): >> Current implementation of elf_load_bsdsyms is broken when loading inside of >> a HVM guest, because it assumes elf_memcpy_safe is able to write into

[Xen-devel] [PATCH v4 1/6] libelf: rewrite symtab/strtab loading for Dom0

2016-01-21 Thread Roger Pau Monne
Current implementation of elf_load_bsdsyms is broken when loading inside of a HVM guest, because it assumes elf_memcpy_safe is able to write into guest memory space, which it is not. Take the oportunity to do some cleanup and properly document how elf_{parse/load}_bsdsyms works. The new