Re: [Xen-devel] [PATCH v4 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c

>>> On 10.09.15 at 07:35, wrote: > On 09/09/2015 23:55, Jan Beulich wrote: On 09.09.15 at 17:16, wrote: >> On 09/09/2015 21:12, Jan Beulich wrote: > On 09.09.15 at 14:56, wrote: >>> Can you please explain more why it

Re: [Xen-devel] [PATCH v4 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c

On 10/09/2015 17:55, Jan Beulich wrote: >>> On 10.09.15 at 11:33, wrote: > On 09/09/2015 16:17, Jan Beulich wrote: On 10.09.15 at 07:35, wrote: >> Seems we still cannot get rid of these strncmp()s. Is this >> acceptable, or should we change

Re: [Xen-devel] [PATCH v4 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c

On 09/09/2015 16:17, Jan Beulich wrote: >>> On 10.09.15 at 07:35, wrote: > On 09/09/2015 23:55, Jan Beulich wrote: On 09.09.15 at 17:16, wrote: >> On 09/09/2015 21:12, Jan Beulich wrote: > On 09.09.15 at 14:56, wrote:

Re: [Xen-devel] [PATCH v4 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c

>>> On 10.09.15 at 12:10, wrote: > Ok. If we add this "enum meaning_of_data", the xen_get_cpufreq_para will > exceed 128Byte, which cannot even pass the compilation. I am not sure how to > deal with this nicely. Do you have a suggestion? Currently afaict the structure

Re: [Xen-devel] [PATCH v4 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c

>>> On 10.09.15 at 11:33, wrote: > On 09/09/2015 16:17, Jan Beulich wrote: On 10.09.15 at 07:35, wrote: >> Seems we still cannot get rid of these strncmp()s. Is this acceptable, >> or should we change "struct cpufreq_driver" to use enum

Re: [Xen-devel] [PATCH v4 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c

On 24/07/2015 22:16, Jan Beulich wrote: >>> On 25.06.15 at 13:17, wrote: > --- a/xen/drivers/acpi/pmstat.c > +++ b/xen/drivers/acpi/pmstat.c > --- a/xen/include/public/sysctl.h > +++ b/xen/include/public/sysctl.h > @@ -315,8 +315,18 @@ struct xen_get_cpufreq_para { >

Re: [Xen-devel] [PATCH v4 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c

On 09/09/2015 16:32, Jan Beulich wrote: >>> On 09.09.15 at 10:11, wrote: > On 24/07/2015 22:16, Jan Beulich wrote: On 25.06.15 at 13:17, wrote: >> --- a/xen/drivers/acpi/pmstat.c >> +++ b/xen/drivers/acpi/pmstat.c >> ---

Re: [Xen-devel] [PATCH v4 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c

>>> On 09.09.15 at 10:49, wrote: > On 09/09/2015 16:32, Jan Beulich wrote: On 09.09.15 at 10:11, wrote: >> On 24/07/2015 22:16, Jan Beulich wrote: > On 25.06.15 at 13:17, wrote: >>> --- a/xen/drivers/acpi/pmstat.c >>>

Re: [Xen-devel] [PATCH v4 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c

>>> On 09.09.15 at 10:11, wrote: > On 24/07/2015 22:16, Jan Beulich wrote: On 25.06.15 at 13:17, wrote: >> --- a/xen/drivers/acpi/pmstat.c >> +++ b/xen/drivers/acpi/pmstat.c >> --- a/xen/include/public/sysctl.h >> +++

Re: [Xen-devel] [PATCH v4 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c

>>> On 09.09.15 at 12:35, wrote: > On 09/09/2015 18:10, Jan Beulich wrote: On 09.09.15 at 11:35, wrote: >>> Using the drinking vessel analogy, we are not putting milk and water >>> into the vessel at the same time. If the producer puts water

Re: [Xen-devel] [PATCH v4 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c

>>> On 09.09.15 at 11:35, wrote: > Using the drinking vessel analogy, we are not putting milk and water into > the vessel at the same time. If the producer puts water into the vessel, then > the consumer simply consumes water; If the producer puts milk into the > vessel,

Re: [Xen-devel] [PATCH v4 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c

On 09/09/2015 18:10, Jan Beulich wrote: >>> On 09.09.15 at 11:35, wrote: >> Using the drinking vessel analogy, we are not putting milk and water >> into the vessel at the same time. If the producer puts water into the >> vessel, then the consumer simply consumes water; If

Re: [Xen-devel] [PATCH v4 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c

On 09/09/2015 17:02, Jan Beulich wrote: >>> On 09.09.15 at 10:49, wrote: > On 09/09/2015 16:32, Jan Beulich wrote: On 09.09.15 at 10:11, wrote: >> On 24/07/2015 22:16, Jan Beulich wrote: > On 25.06.15 at 13:17, wrote:

Re: [Xen-devel] [PATCH v4 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c

>>> On 09.09.15 at 14:56, wrote: > Can you please explain more why it doesn't scale? > From my point of view, any other future value representation can be passed > from the producer to the related consumer through this method. Did you read all of my earlier replies? I

Re: [Xen-devel] [PATCH v4 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c

On 09/09/2015 19:57, Jan Beulich wrote: >>> On 09.09.15 at 12:35, wrote: > On 09/09/2015 18:10, Jan Beulich wrote: On 09.09.15 at 11:35, wrote: >>> Using the drinking vessel analogy, we are not putting milk and water >>>into the vessel at the

Re: [Xen-devel] [PATCH v4 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c

>>> On 09.09.15 at 17:16, wrote: > On 09/09/2015 21:12, Jan Beulich wrote: On 09.09.15 at 14:56, wrote: >> Can you please explain more why it doesn't scale? >> From my point of view, any other future value representation can be >> passed from

Re: [Xen-devel] [PATCH v4 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c

On 09/09/2015 21:12, Jan Beulich wrote: >>> On 09.09.15 at 14:56, wrote: > Can you please explain more why it doesn't scale? > From my point of view, any other future value representation can be > passed from the producer to the related consumer through this method. >

Re: [Xen-devel] [PATCH v4 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c

On 09/09/2015 23:55, Jan Beulich wrote: >>> On 09.09.15 at 17:16, wrote: > On 09/09/2015 21:12, Jan Beulich wrote: On 09.09.15 at 14:56, wrote: >> Can you please explain more why it doesn't scale? >> From my point of view, any other future

Re: [Xen-devel] [PATCH v4 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c

On 25.06.15 at 13:17, wei.w.w...@intel.com wrote: --- a/xen/drivers/acpi/pmstat.c +++ b/xen/drivers/acpi/pmstat.c @@ -192,22 +192,33 @@ static int get_cpufreq_para(struct xen_sysctl_pm_op *op) uint32_t ret = 0; const struct processor_pminfo *pmpt; struct cpufreq_policy

[Xen-devel] [PATCH v4 10/11] x86/intel_pstate: support the use of intel_pstate in pmstat.c

Add support in the pmstat.c so that the xenpm tool can request to access the intel_pstate driver. v4 changes: 1) changed to use the internal_governor struct; 2) coding style change (indentation of gov_num++). Signed-off-by: Wei Wang wei.w.w...@intel.com --- tools/libxc/xc_pm.c | 4 +-