Re: [Xen-devel] [PATCH v4 12/16] bug/x86/arm: Align bug_frames sections.

2016-09-20 Thread Julien Grall
Hi Konrad, On 19/09/2016 22:19, Konrad Rzeszutek Wilk wrote: Signed-off-by: Konrad Rzeszutek Wilk I forgot to mention that with those NITs fixed: Reviewed-by: Julien Grall Thanks. However I noticed (and I recall having it replaced in earlier

Re: [Xen-devel] [PATCH v4 12/16] bug/x86/arm: Align bug_frames sections.

2016-09-19 Thread Konrad Rzeszutek Wilk
On Mon, Sep 19, 2016 at 04:19:55PM -0400, Konrad Rzeszutek Wilk wrote: > > > > Signed-off-by: Konrad Rzeszutek Wilk > > > > I forgot to mention that with those NITs fixed: > > > > Reviewed-by: Julien Grall > > Thanks. > > However I noticed (and I

Re: [Xen-devel] [PATCH v4 12/16] bug/x86/arm: Align bug_frames sections.

2016-09-19 Thread Konrad Rzeszutek Wilk
> > > Signed-off-by: Konrad Rzeszutek Wilk > > I forgot to mention that with those NITs fixed: > > Reviewed-by: Julien Grall Thanks. However I noticed (and I recall having it replaced in earlier versions so I must have in a hurry missed it), but

Re: [Xen-devel] [PATCH v4 12/16] bug/x86/arm: Align bug_frames sections.

2016-09-19 Thread Julien Grall
Hi Konrad, On 16/09/2016 18:38, Konrad Rzeszutek Wilk wrote: Most of the WARN_ON or BUG_ON sections are properly aligned on x86. However on ARM and on x86 assembler the macros don't include any aligment information - hence they end up being the default s/aligment/alignment/ byte

Re: [Xen-devel] [PATCH v4 12/16] bug/x86/arm: Align bug_frames sections.

2016-09-19 Thread Julien Grall
On 19/09/2016 16:34, Julien Grall wrote: Hi Konrad, On 16/09/2016 18:38, Konrad Rzeszutek Wilk wrote: Most of the WARN_ON or BUG_ON sections are properly aligned on x86. However on ARM and on x86 assembler the macros don't include any aligment information - hence they end up being the

Re: [Xen-devel] [PATCH v4 12/16] bug/x86/arm: Align bug_frames sections.

2016-09-19 Thread Jan Beulich
>>> On 16.09.16 at 18:38, wrote: > Most of the WARN_ON or BUG_ON sections are properly aligned on > x86. However on ARM and on x86 assembler the macros don't include > any aligment information - hence they end up being the default > byte granularity. > > On ARM32 it is

[Xen-devel] [PATCH v4 12/16] bug/x86/arm: Align bug_frames sections.

2016-09-16 Thread Konrad Rzeszutek Wilk
Most of the WARN_ON or BUG_ON sections are properly aligned on x86. However on ARM and on x86 assembler the macros don't include any aligment information - hence they end up being the default byte granularity. On ARM32 it is paramount that the aligment is word-size (4) otherwise if one tries to