Re: [Xen-devel] [PATCH v4 14/29] MdePkg/BaseSynchronizationLib: implement 16-bit compare-exchange

2015-02-25 Thread Kinney, Michael D
Ard Biesheuvel, Thank you for providing the implementation of this new function for all supported CPU architectures. The one for IPF looks correct and passes builds. However, I am seeing some build breaks and some issues with the IA32 and X64 versions. The following changes are required to

Re: [Xen-devel] [PATCH v4 14/29] MdePkg/BaseSynchronizationLib: implement 16-bit compare-exchange

2015-02-25 Thread Ard Biesheuvel
On 25 February 2015 at 21:56, Kinney, Michael D michael.d.kin...@intel.com wrote: Ard Biesheuvel, Thank you for providing the implementation of this new function for all supported CPU architectures. The one for IPF looks correct and passes builds. Good. Thanks for confirming that.

Re: [Xen-devel] [PATCH v4 14/29] MdePkg/BaseSynchronizationLib: implement 16-bit compare-exchange

2015-02-23 Thread Ard Biesheuvel
On 18 February 2015 at 08:37, Ard Biesheuvel ard.biesheu...@linaro.org wrote: On 17 February 2015 at 18:40, Jordan Justen jordan.l.jus...@intel.com wrote: Ard, For the subject, I think MdePkg/BaseSynchronizationLib: Add InterlockedCompareExchange16 would be better. OK Acked-by: Jordan

Re: [Xen-devel] [PATCH v4 14/29] MdePkg/BaseSynchronizationLib: implement 16-bit compare-exchange

2015-02-18 Thread Ard Biesheuvel
On 17 February 2015 at 18:40, Jordan Justen jordan.l.jus...@intel.com wrote: Ard, For the subject, I think MdePkg/BaseSynchronizationLib: Add InterlockedCompareExchange16 would be better. OK Acked-by: Jordan Justen jordan.l.jus...@intel.com Thanks Thanks for working to move this to a

Re: [Xen-devel] [PATCH v4 14/29] MdePkg/BaseSynchronizationLib: implement 16-bit compare-exchange

2015-02-17 Thread Jordan Justen
Ard, For the subject, I think MdePkg/BaseSynchronizationLib: Add InterlockedCompareExchange16 would be better. Acked-by: Jordan Justen jordan.l.jus...@intel.com Thanks for working to move this to a common location. Mike, I think Anthony tested the IA32 and X64 implementations with Xen. For

[Xen-devel] [PATCH v4 14/29] MdePkg/BaseSynchronizationLib: implement 16-bit compare-exchange

2015-02-12 Thread Ard Biesheuvel
This implements the function InterlockedCompareExchange16 () for all architectures, using architecture and toolchain specific intrinsics or primitive assembler instructions. Contributed-under: TianoCore Contribution Agreement 1.0 Reviewed-by: Olivier Martin olivier.mar...@arm.com Signed-off-by: