Re: [Xen-devel] [PATCH v5][RFC]xen: sched: convert RTDS from time to event driven model

2016-02-25 Thread Dario Faggioli
On Thu, 2016-02-25 at 12:29 -0500, Tianyang Chen wrote: > On 2/25/2016 5:34 AM, Dario Faggioli wrote: > > > > > Which one ASSERT() fails? > > > The replq_insert() fails because it's already on the replenishment > queue  > when rt_vcpu_wake() is trying to insert a vcpu again. >  > (XEN) Xen call

Re: [Xen-devel] [PATCH v5][RFC]xen: sched: convert RTDS from time to event driven model

2016-02-25 Thread Tianyang Chen
On 2/25/2016 5:34 AM, Dario Faggioli wrote: + * it should be re-inserted back to the replenishment queue. + */ +if ( now >= svc->cur_deadline) +{ +rt_update_deadline(now, svc); +__replq_remove(ops, svc); +} + +if( !__vcpu_on_replq(svc) ) +

Re: [Xen-devel] [PATCH v5][RFC]xen: sched: convert RTDS from time to event driven model

2016-02-25 Thread Dario Faggioli
On Thu, 2016-02-25 at 01:15 -0500, Tianyang Chen wrote: > > On 2/24/2016 9:02 PM, Dario Faggioli wrote: > > Hey, > > > > Here I am, sorry for the delay. :-( > No problem, I think we are almost there. > We probably are, although a few more adjustments in the timer logic is required, IMO. I'll

Re: [Xen-devel] [PATCH v5][RFC]xen: sched: convert RTDS from time to event driven model

2016-02-24 Thread Tianyang Chen
On 2/24/2016 9:02 PM, Dario Faggioli wrote: Hey, Here I am, sorry for the delay. :-( No problem, I think we are almost there. On Mon, 2016-02-08 at 23:33 -0500, Tianyang Chen wrote: Changes since v4: removed unnecessary replenishment queue checks in vcpu_wake() extended

Re: [Xen-devel] [PATCH v5][RFC]xen: sched: convert RTDS from time to event driven model

2016-02-24 Thread Dario Faggioli
Hey, Here I am, sorry for the delay. :-( On Mon, 2016-02-08 at 23:33 -0500, Tianyang Chen wrote: > Changes since v4: > removed unnecessary replenishment queue checks in vcpu_wake() > extended replq_remove() to all cases in vcpu_sleep() > used _deadline_queue_insert() helper function

Re: [Xen-devel] [PATCH v5][RFC]xen: sched: convert RTDS from time to event driven model

2016-02-17 Thread Tianyang Chen
On 2/15/2016 10:55 PM, Meng Xu wrote: Hi Tianyang, Thanks for the patch! Great work and really quick action! :-) I will just comment on something I quickly find out and would look forwarding to Dario's comment. On Mon, Feb 8, 2016 at 11:33 PM, Tianyang Chen

Re: [Xen-devel] [PATCH v5][RFC]xen: sched: convert RTDS from time to event driven model

2016-02-15 Thread Meng Xu
Hi Tianyang, Thanks for the patch! Great work and really quick action! :-) I will just comment on something I quickly find out and would look forwarding to Dario's comment. On Mon, Feb 8, 2016 at 11:33 PM, Tianyang Chen wrote: > Changes since v4: > removed unnecessary

[Xen-devel] [PATCH v5][RFC]xen: sched: convert RTDS from time to event driven model

2016-02-08 Thread Tianyang Chen
Changes since v4: removed unnecessary replenishment queue checks in vcpu_wake() extended replq_remove() to all cases in vcpu_sleep() used _deadline_queue_insert() helper function for both queues _replq_insert() and _replq_remove() program timer internally Changes since v3: