Re: [Xen-devel] [PATCH v5 1/7] xen/arm: Introduce alternative runtime patching

2016-07-22 Thread Julien Grall
On 22/07/16 16:38, Konrad Rzeszutek Wilk wrote: + +origptr = ALT_ORIG_PTR(alt); +writeptr = origptr - (u32 *)_start + writemap; How about just using writeptr += ? I am not sure about your suggestion here. Regardless the Linux code, the origptr will not follow a pattern at

Re: [Xen-devel] [PATCH v5 1/7] xen/arm: Introduce alternative runtime patching

2016-07-22 Thread Konrad Rzeszutek Wilk
> >>+ > >>+origptr = ALT_ORIG_PTR(alt); > >>+writeptr = origptr - (u32 *)_start + writemap; > > > >How about just using writeptr += ? > > I am not sure about your suggestion here. Regardless the Linux code, the > origptr will not follow a pattern at each iteration. So we have to

Re: [Xen-devel] [PATCH v5 1/7] xen/arm: Introduce alternative runtime patching

2016-07-22 Thread Julien Grall
On 22/07/16 15:15, Konrad Rzeszutek Wilk wrote: diff --git a/xen/arch/arm/alternative.c b/xen/arch/arm/alternative.c new file mode 100644 index 000..d00f98e --- /dev/null +++ b/xen/arch/arm/alternative.c Hey! Hi Konrad, I've some comments, most of them are light. What I am concerned

Re: [Xen-devel] [PATCH v5 1/7] xen/arm: Introduce alternative runtime patching

2016-07-22 Thread Konrad Rzeszutek Wilk
> diff --git a/xen/arch/arm/alternative.c b/xen/arch/arm/alternative.c > new file mode 100644 > index 000..d00f98e > --- /dev/null > +++ b/xen/arch/arm/alternative.c Hey! I've some comments, most of them are light. What I am concerned most is the difference between comments in the header vs

[Xen-devel] [PATCH v5 1/7] xen/arm: Introduce alternative runtime patching

2016-07-20 Thread Julien Grall
Some of the processor erratum will require to modify code sequence. As those modifications may impact the performance, they should only be enabled on affected cores. Furthermore, Xen may also want to take advantage of new hardware features coming up with v8.1 and v8.2. This patch adds an