Re: [Xen-devel] [PATCH v5 2/6] x86: allow reading MSR_IA32_TSC with XENPF_resource_op

2015-01-23 Thread Jan Beulich
On 23.01.15 at 09:42, chao.p.p...@linux.intel.com wrote: Except that MSR_IA32_TSC will looks heterogeneous. But since we already treat it as a special case, I have no problem here. And if we do so, even the first patch to add irq_disable ability is not needed. Sounds to me that the

Re: [Xen-devel] [PATCH v5 2/6] x86: allow reading MSR_IA32_TSC with XENPF_resource_op

2015-01-23 Thread Chao Peng
On Thu, Jan 22, 2015 at 02:09:37PM +, Jan Beulich wrote: On 22.01.15 at 15:03, andrew.coop...@citrix.com wrote: On 22/01/15 13:36, Jan Beulich wrote: On 22.01.15 at 13:53, chao.p.p...@linux.intel.com wrote: On Thu, Jan 22, 2015 at 11:20:15AM +, Jan Beulich wrote: On 21.01.15 at

Re: [Xen-devel] [PATCH v5 2/6] x86: allow reading MSR_IA32_TSC with XENPF_resource_op

2015-01-22 Thread Jan Beulich
On 21.01.15 at 12:19, chao.p.p...@linux.intel.com wrote: --- a/xen/arch/x86/platform_hypercall.c +++ b/xen/arch/x86/platform_hypercall.c @@ -61,7 +61,7 @@ long cpu_down_helper(void *data); long core_parking_helper(void *data); uint32_t get_cur_idle_nums(void); -#define

Re: [Xen-devel] [PATCH v5 2/6] x86: allow reading MSR_IA32_TSC with XENPF_resource_op

2015-01-22 Thread Andrew Cooper
On 22/01/15 13:36, Jan Beulich wrote: On 22.01.15 at 13:53, chao.p.p...@linux.intel.com wrote: On Thu, Jan 22, 2015 at 11:20:15AM +, Jan Beulich wrote: On 21.01.15 at 12:19, chao.p.p...@linux.intel.com wrote: --- a/xen/arch/x86/platform_hypercall.c +++ b/xen/arch/x86/platform_hypercall.c

Re: [Xen-devel] [PATCH v5 2/6] x86: allow reading MSR_IA32_TSC with XENPF_resource_op

2015-01-22 Thread Chao Peng
On Thu, Jan 22, 2015 at 11:20:15AM +, Jan Beulich wrote: On 21.01.15 at 12:19, chao.p.p...@linux.intel.com wrote: --- a/xen/arch/x86/platform_hypercall.c +++ b/xen/arch/x86/platform_hypercall.c @@ -61,7 +61,7 @@ long cpu_down_helper(void *data); long core_parking_helper(void *data);

Re: [Xen-devel] [PATCH v5 2/6] x86: allow reading MSR_IA32_TSC with XENPF_resource_op

2015-01-22 Thread Jan Beulich
On 22.01.15 at 13:53, chao.p.p...@linux.intel.com wrote: On Thu, Jan 22, 2015 at 11:20:15AM +, Jan Beulich wrote: On 21.01.15 at 12:19, chao.p.p...@linux.intel.com wrote: --- a/xen/arch/x86/platform_hypercall.c +++ b/xen/arch/x86/platform_hypercall.c @@ -61,7 +61,7 @@ long

[Xen-devel] [PATCH v5 2/6] x86: allow reading MSR_IA32_TSC with XENPF_resource_op

2015-01-21 Thread Chao Peng
Memory bandwidth monitoring requires system time information returned along with the monitoring counter to verify the correctness of the counter value and to calculate the time elapsed between two samplings. Add MSR_IA32_TSC to the read path and increase RESOURCE_ACCESS_MAX_ENTRIES to 3.