Re: [Xen-devel] [PATCH v5 22/24] libxlu: introduce new APIs

2015-02-16 Thread Wei Liu
On Fri, Feb 13, 2015 at 02:12:29PM +, Ian Jackson wrote: Wei Liu writes ([PATCH v5 22/24] libxlu: introduce new APIs): These APIs can be used to manipulate XLU_ConfigValue and XLU_ConfigList. +if (value-type != XLU_STRING) { +if (!dont_warn) +

Re: [Xen-devel] [PATCH v5 22/24] libxlu: introduce new APIs

2015-02-16 Thread Wei Liu
On Mon, Feb 16, 2015 at 07:10:46PM +, Wei Liu wrote: [...] (being a function or macro which always returns EINVAL), or some such. Do feel very keen about this since the format string differs from Don't... functions. And it's only one printf anyway. Wei. Thanks, Ian.

Re: [Xen-devel] [PATCH v5 22/24] libxlu: introduce new APIs

2015-02-13 Thread Ian Jackson
Wei Liu writes ([PATCH v5 22/24] libxlu: introduce new APIs): These APIs can be used to manipulate XLU_ConfigValue and XLU_ConfigList. +if (value-type != XLU_STRING) { +if (!dont_warn) +fprintf(cfg-report, warning: value is not a string\n); +*value_r = NULL;

[Xen-devel] [PATCH v5 22/24] libxlu: introduce new APIs

2015-02-12 Thread Wei Liu
These APIs can be used to manipulate XLU_ConfigValue and XLU_ConfigList. APIs introduced: 1. xlu_cfg_value_type 2. xlu_cfg_value_get_string 3. xlu_cfg_value_get_list 4. xlu_cfg_get_listitem2 Move some definitions from private header to public header as needed. Signed-off-by: Wei Liu