Re: [Xen-devel] [PATCH v5 3/3] xen/arm: vgic_migrate_irq: do not race against GIC_IRQ_GUEST_MIGRATING

2017-04-03 Thread Stefano Stabellini
On Mon, 3 Apr 2017, Julien Grall wrote: > Hi Stefano, > > On 31/03/17 21:24, Stefano Stabellini wrote: > > On Fri, 31 Mar 2017, Julien Grall wrote: > > > On 30/03/17 00:47, Stefano Stabellini wrote: > > > > On Fri, 3 Mar 2017, Julien Grall wrote: > > > What you described is not a data corruption

Re: [Xen-devel] [PATCH v5 3/3] xen/arm: vgic_migrate_irq: do not race against GIC_IRQ_GUEST_MIGRATING

2017-04-03 Thread Julien Grall
Hi Stefano, On 31/03/17 21:24, Stefano Stabellini wrote: On Fri, 31 Mar 2017, Julien Grall wrote: On 30/03/17 00:47, Stefano Stabellini wrote: On Fri, 3 Mar 2017, Julien Grall wrote: What you described is not a data corruption to me. No, it is not, thanks to the previous two patches. The

Re: [Xen-devel] [PATCH v5 3/3] xen/arm: vgic_migrate_irq: do not race against GIC_IRQ_GUEST_MIGRATING

2017-03-31 Thread Stefano Stabellini
On Fri, 31 Mar 2017, Julien Grall wrote: > Hi Stefano, > > On 30/03/17 00:47, Stefano Stabellini wrote: > > On Fri, 3 Mar 2017, Julien Grall wrote: > > > Hi Stefano, > > > > > > On 01/03/17 22:15, Stefano Stabellini wrote: > > > > A potential race condition occurs when vgic_migrate_irq is called

Re: [Xen-devel] [PATCH v5 3/3] xen/arm: vgic_migrate_irq: do not race against GIC_IRQ_GUEST_MIGRATING

2017-03-31 Thread Julien Grall
Hi Stefano, On 30/03/17 00:47, Stefano Stabellini wrote: On Fri, 3 Mar 2017, Julien Grall wrote: Hi Stefano, On 01/03/17 22:15, Stefano Stabellini wrote: A potential race condition occurs when vgic_migrate_irq is called a second time, while GIC_IRQ_GUEST_MIGRATING is already set. In that

Re: [Xen-devel] [PATCH v5 3/3] xen/arm: vgic_migrate_irq: do not race against GIC_IRQ_GUEST_MIGRATING

2017-03-29 Thread Stefano Stabellini
On Fri, 3 Mar 2017, Julien Grall wrote: > Hi Stefano, > > On 01/03/17 22:15, Stefano Stabellini wrote: > > A potential race condition occurs when vgic_migrate_irq is called a > > second time, while GIC_IRQ_GUEST_MIGRATING is already set. In that case, > > vgic_migrate_irq takes a different vgic

Re: [Xen-devel] [PATCH v5 3/3] xen/arm: vgic_migrate_irq: do not race against GIC_IRQ_GUEST_MIGRATING

2017-03-03 Thread Julien Grall
Hi Stefano, On 01/03/17 22:15, Stefano Stabellini wrote: A potential race condition occurs when vgic_migrate_irq is called a second time, while GIC_IRQ_GUEST_MIGRATING is already set. In that case, vgic_migrate_irq takes a different vgic lock from gic_update_one_lr. Hmmm, vgic_migrate_irq

[Xen-devel] [PATCH v5 3/3] xen/arm: vgic_migrate_irq: do not race against GIC_IRQ_GUEST_MIGRATING

2017-03-01 Thread Stefano Stabellini
A potential race condition occurs when vgic_migrate_irq is called a second time, while GIC_IRQ_GUEST_MIGRATING is already set. In that case, vgic_migrate_irq takes a different vgic lock from gic_update_one_lr. vgic_migrate_irq running concurrently with gic_update_one_lr could cause data