Re: [Xen-devel] [PATCH v5 p2 04/19] xen/arm: Implement hypercall DOMCTL_{, un}bind_pt_pirq

2015-04-17 Thread Daniel De Graaf
On 04/16/2015 10:55 AM, Ian Campbell wrote: On Thu, 2015-04-09 at 16:09 +0100, Julien Grall wrote: From: Julien Grall I've left the XSM related quotes untrimmed and CCd Daniel. I think it's all code motion (making x86 specific things generic), so perhaps no ack needed but an opportunity to na

Re: [Xen-devel] [PATCH v5 p2 04/19] xen/arm: Implement hypercall DOMCTL_{, un}bind_pt_pirq

2015-04-17 Thread Ian Campbell
On Fri, 2015-04-17 at 07:02 +0100, Julien Grall wrote: > Hi Ian, > > On 16/04/2015 16:40, Ian Campbell wrote: > > On Thu, 2015-04-16 at 16:20 +0100, Julien Grall wrote: > Concerning XSM, even if ARM is using one hypercall rather than 2, the > resulting check is nearly the same. > >

Re: [Xen-devel] [PATCH v5 p2 04/19] xen/arm: Implement hypercall DOMCTL_{, un}bind_pt_pirq

2015-04-16 Thread Julien Grall
Hi Ian, On 16/04/2015 16:40, Ian Campbell wrote: On Thu, 2015-04-16 at 16:20 +0100, Julien Grall wrote: Concerning XSM, even if ARM is using one hypercall rather than 2, the resulting check is nearly the same. XSM PHYSDEVOP_map_pirq: 1) Check if the current domain can add resource to the

Re: [Xen-devel] [PATCH v5 p2 04/19] xen/arm: Implement hypercall DOMCTL_{, un}bind_pt_pirq

2015-04-16 Thread Ian Campbell
On Thu, 2015-04-16 at 16:20 +0100, Julien Grall wrote: > >> Concerning XSM, even if ARM is using one hypercall rather than 2, the > >> resulting check is nearly the same. > >> > >> XSM PHYSDEVOP_map_pirq: > >> 1) Check if the current domain can add resource to the domain > >> 2) Check if

Re: [Xen-devel] [PATCH v5 p2 04/19] xen/arm: Implement hypercall DOMCTL_{, un}bind_pt_pirq

2015-04-16 Thread Julien Grall
Hi Ian, On 16/04/2015 15:55, Ian Campbell wrote: On Thu, 2015-04-09 at 16:09 +0100, Julien Grall wrote: From: Julien Grall I've left the XSM related quotes untrimmed and CCd Daniel. I think it's all code motion (making x86 specific things generic), so perhaps no ack needed but an opportunity

Re: [Xen-devel] [PATCH v5 p2 04/19] xen/arm: Implement hypercall DOMCTL_{, un}bind_pt_pirq

2015-04-16 Thread Ian Campbell
On Thu, 2015-04-09 at 16:09 +0100, Julien Grall wrote: > From: Julien Grall I've left the XSM related quotes untrimmed and CCd Daniel. I think it's all code motion (making x86 specific things generic), so perhaps no ack needed but an opportunity to nack instead ;-) > On x86, an IRQ is assigned i

[Xen-devel] [PATCH v5 p2 04/19] xen/arm: Implement hypercall DOMCTL_{, un}bind_pt_pirq

2015-04-09 Thread Julien Grall
From: Julien Grall On x86, an IRQ is assigned in 2 steps to an HVM guest: - The toolstack is calling PHYSDEVOP_map_pirq in order to create a guest PIRQ (IRQ bound to an event channel) - The emulator (QEMU) is calling DOMCTL_bind_pt_irq in order to bind the IRQ On ARM, there is no