Re: [Xen-devel] [PATCH v6][RFC]xen: sched: convert RTDS from time to event driven model

2016-03-04 Thread Dario Faggioli
On Fri, 2016-02-26 at 13:33 -0500, Chen, Tianyang wrote: > Attached. > Hey, here I am... sorry it took a bit. I've had a look, and I've been able to come up with some code that I at least do not dislike too much! ;-P Have a look at the attached patch (you should apply it on top of the

Re: [Xen-devel] [PATCH v6][RFC]xen: sched: convert RTDS from time to event driven model

2016-02-26 Thread Chen, Tianyang
Attached. Tianyang On 2016-02-26 13:09, Dario Faggioli wrote: On Fri, 2016-02-26 at 12:28 -0500, Tianyang Chen wrote: > So, have you made other changes wrt v6 when trying this? The v6 doesn't have the if statement commented out when I submitted it.  But I tried commenting it out, the

Re: [Xen-devel] [PATCH v6][RFC]xen: sched: convert RTDS from time to event driven model

2016-02-26 Thread Dario Faggioli
On Fri, 2016-02-26 at 12:28 -0500, Tianyang Chen wrote: > > So, have you made other changes wrt v6 when trying this? > The v6 doesn't have the if statement commented out when I submitted > it.  > But I tried commenting it out, the assertion failed. > Ok, thanks for these tests. Can you send (just

Re: [Xen-devel] [PATCH v6][RFC]xen: sched: convert RTDS from time to event driven model

2016-02-26 Thread Tianyang Chen
On 2/26/2016 4:11 AM, Dario Faggioli wrote: It looks like the current code doesn't add a vcpu to the replenishment queue when vcpu_insert() is called. When the scheduler is initialized, all the vcpus are added to the replenishment queue after waking up from sleep. This needs to be changed (add

Re: [Xen-devel] [PATCH v6][RFC]xen: sched: convert RTDS from time to event driven model

2016-02-26 Thread Dario Faggioli
On Fri, 2016-02-26 at 00:15 -0500, Tianyang Chen wrote: > On 2/25/2016 6:31 PM, Dario Faggioli wrote: > > As far as my opinion goes, this patch is not ready to > > go in > > right now (as I said, I've got questions and comments), but its > > status > > is way past RFC. > > > Oh OK, I had the

Re: [Xen-devel] [PATCH v6][RFC]xen: sched: convert RTDS from time to event driven model

2016-02-25 Thread Tianyang Chen
On 2/25/2016 6:31 PM, Dario Faggioli wrote: Hey again, Thanks for turning up so quickly. We are getting closer and closer, although (of course :-)) I have some more comments. However, is there a particular reason why you are keeping the RFC tag? Until you do that, it's like saying that you

Re: [Xen-devel] [PATCH v6][RFC]xen: sched: convert RTDS from time to event driven model

2016-02-25 Thread Dario Faggioli
Hey again, Thanks for turning up so quickly. We are getting closer and closer, although (of course :-)) I have some more comments. However, is there a particular reason why you are keeping the RFC tag? Until you do that, it's like saying that you are chasing feedback, but you do not think

[Xen-devel] [PATCH v6][RFC]xen: sched: convert RTDS from time to event driven model

2016-02-25 Thread Tianyang Chen
changes since v5: removed unnecessary vcpu_on_replq() checks deadline_queue_insert() returns a flag to indicate if it's needed to re-program the timer removed unnecessary timer checks added helper functions to remove vcpus from queues coding style Changes since v4: