Re: [Xen-devel] [PATCH v6 08/24] xsplice: Add helper elf routines

2016-04-08 Thread Jan Beulich
>>> On 09.04.16 at 00:10, wrote: > On 08/04/16 22:26, Konrad Rzeszutek Wilk wrote: >> On Fri, Apr 08, 2016 at 03:53:44PM +0100, Andrew Cooper wrote: >>> On 07/04/16 04:49, Konrad Rzeszutek Wilk wrote: +nsym = symtab_sec->sec->sh_size /

Re: [Xen-devel] [PATCH v6 08/24] xsplice: Add helper elf routines

2016-04-08 Thread Andrew Cooper
On 08/04/16 22:26, Konrad Rzeszutek Wilk wrote: > On Fri, Apr 08, 2016 at 03:53:44PM +0100, Andrew Cooper wrote: >> On 07/04/16 04:49, Konrad Rzeszutek Wilk wrote: >>> +static int elf_resolve_sections(struct xsplice_elf *elf, const void *data) >>> +{ >>> +struct xsplice_elf_sec *sec; >>> +

Re: [Xen-devel] [PATCH v6 08/24] xsplice: Add helper elf routines

2016-04-08 Thread Konrad Rzeszutek Wilk
On Fri, Apr 08, 2016 at 03:53:44PM +0100, Andrew Cooper wrote: > On 07/04/16 04:49, Konrad Rzeszutek Wilk wrote: > > +static int elf_resolve_sections(struct xsplice_elf *elf, const void *data) > > +{ > > +struct xsplice_elf_sec *sec; > > +unsigned int i; > > +Elf_Off delta; > > +

Re: [Xen-devel] [PATCH v6 08/24] xsplice: Add helper elf routines

2016-04-08 Thread Andrew Cooper
On 07/04/16 04:49, Konrad Rzeszutek Wilk wrote: > +static int elf_resolve_sections(struct xsplice_elf *elf, const void *data) > +{ > +struct xsplice_elf_sec *sec; > +unsigned int i; > +Elf_Off delta; > +int rc; > + > +/* xsplice_elf_load sanity checked e_shnum. */ > +sec =

Re: [Xen-devel] [PATCH v6 08/24] xsplice: Add helper elf routines

2016-04-08 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH v6 08/24] xsplice: Add helper elf routines"): > On 07/04/16 17:19, Ian Jackson wrote: > > My understanding of this is that the purpose of this machinery is to > > supply binary runtime patches to the hypervisor. So I think someone > > who can inject malicious

Re: [Xen-devel] [PATCH v6 08/24] xsplice: Add helper elf routines

2016-04-07 Thread Konrad Rzeszutek Wilk
On Thu, Apr 07, 2016 at 05:19:37PM +0100, Ian Jackson wrote: > Konrad Rzeszutek Wilk writes ("[PATCH v6 08/24] xsplice: Add helper elf > routines"): > > From: Ross Lagerwall > > > > Add Elf routines and data structures in preparation for loading an > > xSplice

Re: [Xen-devel] [PATCH v6 08/24] xsplice: Add helper elf routines

2016-04-07 Thread Andrew Cooper
On 07/04/16 17:19, Ian Jackson wrote: > Konrad Rzeszutek Wilk writes ("[PATCH v6 08/24] xsplice: Add helper elf > routines"): >> From: Ross Lagerwall >> >> Add Elf routines and data structures in preparation for loading an >> xSplice payload. >> >> We make an

Re: [Xen-devel] [PATCH v6 08/24] xsplice: Add helper elf routines

2016-04-07 Thread Jan Beulich
>>> On 07.04.16 at 18:19, wrote: > Konrad Rzeszutek Wilk writes ("[PATCH v6 08/24] xsplice: Add helper elf > routines"): >> From: Ross Lagerwall >> >> Add Elf routines and data structures in preparation for loading an >> xSplice payload. >>

Re: [Xen-devel] [PATCH v6 08/24] xsplice: Add helper elf routines

2016-04-07 Thread Ian Jackson
Konrad Rzeszutek Wilk writes ("[PATCH v6 08/24] xsplice: Add helper elf routines"): > From: Ross Lagerwall > > Add Elf routines and data structures in preparation for loading an > xSplice payload. > > We make an assumption that the max number of sections an ELF

[Xen-devel] [PATCH v6 08/24] xsplice: Add helper elf routines

2016-04-06 Thread Konrad Rzeszutek Wilk
From: Ross Lagerwall Add Elf routines and data structures in preparation for loading an xSplice payload. We make an assumption that the max number of sections an ELF payload can have is 64. We can in future make this be dependent on the names of the sections and