Re: [Xen-devel] [PATCH v8 4/7] VT-d: Use one function to update both remapped and posted IRTE

2017-02-22 Thread Jan Beulich
>>> On 22.02.17 at 08:12, wrote: > On Wed, Feb 22, 2017 at 02:10:25AM -0700, Jan Beulich wrote: > On 22.02.17 at 02:53, wrote: >>> On Tue, Nov 22, 2016 at 05:58:56PM +0800, Jan Beulich wrote: > @@ -637,7 +657,23 @@ static int msi_msg_to_remap_entry( > remap_rte->address_hi = 0; >

Re: [Xen-devel] [PATCH v8 4/7] VT-d: Use one function to update both remapped and posted IRTE

2017-02-22 Thread Chao Gao
On Wed, Feb 22, 2017 at 02:10:25AM -0700, Jan Beulich wrote: On 22.02.17 at 02:53, wrote: >> On Tue, Nov 22, 2016 at 05:58:56PM +0800, Jan Beulich wrote: @@ -637,7 +657,23 @@ static int msi_msg_to_remap_entry( remap_rte->address_hi = 0; remap_rte->data = index - i; >>

Re: [Xen-devel] [PATCH v8 4/7] VT-d: Use one function to update both remapped and posted IRTE

2017-02-22 Thread Jan Beulich
>>> On 22.02.17 at 02:53, wrote: > On Tue, Nov 22, 2016 at 05:58:56PM +0800, Jan Beulich wrote: > On 18.11.16 at 02:57, wrote: >>> else >>> -new_ire.remap.dst = ((msg->address_lo >> MSI_ADDR_DEST_ID_SHIFT) >>> - & 0xff) << 8; >>> +{ >>> +ne

Re: [Xen-devel] [PATCH v8 4/7] VT-d: Use one function to update both remapped and posted IRTE

2017-02-22 Thread Chao Gao
On Tue, Nov 22, 2016 at 05:58:56PM +0800, Jan Beulich wrote: On 18.11.16 at 02:57, wrote: >> @@ -597,31 +598,50 @@ static int msi_msg_to_remap_entry( > >Considering you basically re-do most of the function, I think there's >some more adjustment necessary (or at least very desirable) here. > >

Re: [Xen-devel] [PATCH v8 4/7] VT-d: Use one function to update both remapped and posted IRTE

2016-11-22 Thread Jan Beulich
>>> On 18.11.16 at 02:57, wrote: > @@ -597,31 +598,50 @@ static int msi_msg_to_remap_entry( Considering you basically re-do most of the function, I think there's some more adjustment necessary (or at least very desirable) here. > > memcpy(&new_ire, iremap_entry, sizeof(struct iremap_entry

Re: [Xen-devel] [PATCH v8 4/7] VT-d: Use one function to update both remapped and posted IRTE

2016-11-21 Thread Wu, Feng
> -Original Message- > From: Tian, Kevin > Sent: Friday, November 18, 2016 12:31 PM > To: Wu, Feng ; xen-devel@lists.xen.org > Cc: jbeul...@suse.com; andrew.coop...@citrix.com; > george.dun...@eu.citrix.com; dario.faggi...@citrix.com > Subject: RE: [PATCH v8 4/7] VT-d: Use one function to

Re: [Xen-devel] [PATCH v8 4/7] VT-d: Use one function to update both remapped and posted IRTE

2016-11-17 Thread Tian, Kevin
> From: Wu, Feng > Sent: Friday, November 18, 2016 9:57 AM > > Use one function to update both remapped IRTE and posted IRET. > > Signed-off-by: Feng Wu > --- > v8: > - Newly added > > xen/drivers/passthrough/vtd/intremap.c | 162 > ++--- > 1 file changed, 66 inser

[Xen-devel] [PATCH v8 4/7] VT-d: Use one function to update both remapped and posted IRTE

2016-11-17 Thread Feng Wu
Use one function to update both remapped IRTE and posted IRET. Signed-off-by: Feng Wu --- v8: - Newly added xen/drivers/passthrough/vtd/intremap.c | 162 ++--- 1 file changed, 66 insertions(+), 96 deletions(-) diff --git a/xen/drivers/passthrough/vtd/intremap.c b/x