Re: [Xen-devel] [PATCHv2 for-4.10] xen/arm: guest_walk: Fix check again the IPS

2017-10-11 Thread Stefano Stabellini
On Wed, 11 Oct 2017, Sergej Proskurin wrote: > Hi Julien, > > On 10/11/2017 04:57 PM, Julien Grall wrote: > > > > > > On 11/10/17 15:51, Sergej Proskurin wrote: > >> Hi Julien, > > > > Hi, > > > >> On 10/11/2017 04:29 PM, Julien Grall wrote: > >>> The function get_ipa_output_size is check

Re: [Xen-devel] [PATCHv2 for-4.10] xen/arm: guest_walk: Fix check again the IPS

2017-10-11 Thread Sergej Proskurin
Hi Julien, On 10/11/2017 04:57 PM, Julien Grall wrote: > > > On 11/10/17 15:51, Sergej Proskurin wrote: >> Hi Julien, > > Hi, > >> On 10/11/2017 04:29 PM, Julien Grall wrote: >>> The function get_ipa_output_size is check whether the input size >>> configured by the guest is valid and will

Re: [Xen-devel] [PATCHv2 for-4.10] xen/arm: guest_walk: Fix check again the IPS

2017-10-11 Thread Julien Grall
On 11/10/17 15:51, Sergej Proskurin wrote: Hi Julien, Hi, On 10/11/2017 04:29 PM, Julien Grall wrote: The function get_ipa_output_size is check whether the input size configured by the guest is valid and will return it. The check is done with the IPS already shifted against

Re: [Xen-devel] [PATCHv2 for-4.10] xen/arm: guest_walk: Fix check again the IPS

2017-10-11 Thread Sergej Proskurin
Hi Julien, On 10/11/2017 04:29 PM, Julien Grall wrote: > The function get_ipa_output_size is check whether the input size > configured by the guest is valid and will return it. > > The check is done with the IPS already shifted against > TCR_EL1_IPS_48_BIT. However the constant has been defined

[Xen-devel] [PATCHv2 for-4.10] xen/arm: guest_walk: Fix check again the IPS

2017-10-11 Thread Julien Grall
The function get_ipa_output_size is check whether the input size configured by the guest is valid and will return it. The check is done with the IPS already shifted against TCR_EL1_IPS_48_BIT. However the constant has been defined with the shift included, resulting the check always been false.