Re: [Xen-devel] [RFC] libxl: relax readonly check introduced by XSA-142 fix

2015-11-13 Thread Ian Campbell
On Thu, 2015-11-12 at 10:53 -0700, Jim Fehlig wrote: > Ian Campbell wrote: > > On Thu, 2015-11-12 at 08:45 -0700, Jim Fehlig wrote: > > >   > > > > The commit message doesn't say anything about AHCI. Are AHCI disks > > > > actually emulated correctly by QEMU with readonly=on? > > > I just double

Re: [Xen-devel] [RFC] libxl: relax readonly check introduced by XSA-142 fix

2015-11-12 Thread Stefano Stabellini
On Wed, 11 Nov 2015, Jim Fehlig wrote: > Hi All, > > Apologies for only noticing the fix for XSA-142 as it starting flowing to our > various downstreams. The current fix seems like quite a big hammer IMO. qemu > doesn't support readonly IDE/SATA disks > > # /usr/lib/xen/bin/qemu-system-i386

Re: [Xen-devel] [RFC] libxl: relax readonly check introduced by XSA-142 fix

2015-11-12 Thread Jim Fehlig
Stefano Stabellini wrote: > On Wed, 11 Nov 2015, Jim Fehlig wrote: > >> Hi All, >> >> Apologies for only noticing the fix for XSA-142 as it starting flowing to our >> various downstreams. The current fix seems like quite a big hammer IMO. qemu >> doesn't support readonly IDE/SATA disks >> >> #

Re: [Xen-devel] [RFC] libxl: relax readonly check introduced by XSA-142 fix

2015-11-12 Thread Jim Fehlig
Ian Campbell wrote: > On Thu, 2015-11-12 at 08:45 -0700, Jim Fehlig wrote: >> >>> The commit message doesn't say anything about AHCI. Are AHCI disks >>> actually emulated correctly by QEMU with readonly=on? >> I just double checked, and good thing since AHCI + readonly is another >> rejected >>

Re: [Xen-devel] [RFC] libxl: relax readonly check introduced by XSA-142 fix

2015-11-12 Thread Ian Campbell
On Thu, 2015-11-12 at 08:45 -0700, Jim Fehlig wrote: >  > > The commit message doesn't say anything about AHCI. Are AHCI disks > > actually emulated correctly by QEMU with readonly=on? > > I just double checked, and good thing since AHCI + readonly is another > rejected > combination > >

Re: [Xen-devel] [RFC] libxl: relax readonly check introduced by XSA-142 fix

2015-11-12 Thread Ian Jackson
Jim Fehlig writes ("Re: [RFC] libxl: relax readonly check introduced by XSA-142 fix"): > Stefano Stabellini wrote: > > I don't think that libxl CODING_STYLE requires brackets for one statement > > blocks. But I won't enforce it. Thanks for all the work on this, Jim, and Stefano. It looks good

[Xen-devel] [RFC] libxl: relax readonly check introduced by XSA-142 fix

2015-11-11 Thread Jim Fehlig
Hi All, Apologies for only noticing the fix for XSA-142 as it starting flowing to our various downstreams. The current fix seems like quite a big hammer IMO. qemu doesn't support readonly IDE/SATA disks # /usr/lib/xen/bin/qemu-system-i386 -drive