Re: [Xen-devel] [RFC PATCH 4/4] libxl: support creation and destruction of static shared memory areas

2017-08-09 Thread Zhongze Liu
2017-08-08 18:49 GMT+08:00 Wei Liu : > On Sat, Aug 05, 2017 at 01:26:37AM +0800, Zhongze Liu wrote: >> Hi Wei, >> >> Thank you for reviewing my patch. >> >> 2017-08-04 23:20 GMT+08:00 Wei Liu : >> > I skim through this patch and have some questions. >> >

Re: [Xen-devel] [RFC PATCH 4/4] libxl: support creation and destruction of static shared memory areas

2017-08-09 Thread Zhongze Liu
2017-08-08 18:56 GMT+08:00 Wei Liu : > On Tue, Aug 08, 2017 at 11:49:35AM +0100, Wei Liu wrote: >> On Sat, Aug 05, 2017 at 01:26:37AM +0800, Zhongze Liu wrote: >> > Hi Wei, >> > >> > Thank you for reviewing my patch. >> > >> > 2017-08-04 23:20 GMT+08:00 Wei Liu

Re: [Xen-devel] [RFC PATCH 4/4] libxl: support creation and destruction of static shared memory areas

2017-08-08 Thread Wei Liu
On Tue, Aug 08, 2017 at 11:49:35AM +0100, Wei Liu wrote: > On Sat, Aug 05, 2017 at 01:26:37AM +0800, Zhongze Liu wrote: > > Hi Wei, > > > > Thank you for reviewing my patch. > > > > 2017-08-04 23:20 GMT+08:00 Wei Liu : > > > I skim through this patch and have some questions.

Re: [Xen-devel] [RFC PATCH 4/4] libxl: support creation and destruction of static shared memory areas

2017-08-08 Thread Wei Liu
On Sat, Aug 05, 2017 at 01:26:37AM +0800, Zhongze Liu wrote: > Hi Wei, > > Thank you for reviewing my patch. > > 2017-08-04 23:20 GMT+08:00 Wei Liu : > > I skim through this patch and have some questions. > > > > On Fri, Aug 04, 2017 at 10:20:25AM +0800, Zhongze Liu wrote: >

Re: [Xen-devel] [RFC PATCH 4/4] libxl: support creation and destruction of static shared memory areas

2017-08-04 Thread Zhongze Liu
Hi Wei, Thank you for reviewing my patch. 2017-08-04 23:20 GMT+08:00 Wei Liu : > I skim through this patch and have some questions. > > On Fri, Aug 04, 2017 at 10:20:25AM +0800, Zhongze Liu wrote: >> + >> +static int libxl__sshm_add_master(libxl__gc *gc, uint32_t domid, >> +

Re: [Xen-devel] [RFC PATCH 4/4] libxl: support creation and destruction of static shared memory areas

2017-08-04 Thread Wei Liu
I skim through this patch and have some questions. On Fri, Aug 04, 2017 at 10:20:25AM +0800, Zhongze Liu wrote: > + > +static int libxl__sshm_add_master(libxl__gc *gc, uint32_t domid, > + libxl_static_shm *sshm) > +{ > +int rc, aborting; > +char

[Xen-devel] [RFC PATCH 4/4] libxl: support creation and destruction of static shared memory areas

2017-08-03 Thread Zhongze Liu
creation: * Check for further errors in the static_shm configs: overlapping areas, invalid ranges, duplicated master domain, no master domain etc. * Add code for writing infomations of static shared memory areas into the appropriate xenstore paths. * use xc_domain_add_to_physmap_batch to do