Re: [Xen-devel] [RFC PATCH v2 01/16] hvmloader: Fix scratch_alloc to avoid overlaps

2015-11-10 Thread Jan Beulich
>>> On 26.10.15 at 17:03, wrote: > --- a/tools/firmware/hvmloader/util.c > +++ b/tools/firmware/hvmloader/util.c > @@ -479,7 +479,7 @@ void *scratch_alloc(uint32_t size, uint32_t align) > align = 16; > > s = (scratch_start + align - 1) & ~(align - 1); >

Re: [Xen-devel] [RFC PATCH v2 01/16] hvmloader: Fix scratch_alloc to avoid overlaps

2015-11-03 Thread Ian Campbell
On Mon, 2015-10-26 at 16:03 +, Anthony PERARD wrote: Please remember to CC the relevant maintainers. > scratch_alloc() set scratch_start to the last byte of the current > allocation.  The value of scratch_start is then reused as is (if it is > already aligned) in the next allocation.  This

[Xen-devel] [RFC PATCH v2 01/16] hvmloader: Fix scratch_alloc to avoid overlaps

2015-10-26 Thread Anthony PERARD
scratch_alloc() set scratch_start to the last byte of the current allocation. The value of scratch_start is then reused as is (if it is already aligned) in the next allocation. This result in a potential reuse of the last byte of the previous allocation. Signed-off-by: Anthony PERARD