Re: [Xen-devel] [RFC v2][PATCH] arm-acpi: Add ITS Support for Dom0

2017-06-13 Thread Julien Grall
On 13/06/17 12:44, Manish Jaggi wrote: On 6/13/2017 4:58 PM, Julien Grall wrote: On 13/06/17 12:02, Manish Jaggi wrote: Will the below code be ok? If you noticed, I didn't say this code is wrong. Instead I asked why you use the same ID. Meaning, is there anything in the DSDT requiring this va

Re: [Xen-devel] [RFC v2][PATCH] arm-acpi: Add ITS Support for Dom0

2017-06-13 Thread Manish Jaggi
On 6/13/2017 4:58 PM, Julien Grall wrote: On 13/06/17 12:02, Manish Jaggi wrote: Will the below code be ok? If you noticed, I didn't say this code is wrong. Instead I asked why you use the same ID. Meaning, is there anything in the DSDT requiring this value? + int tras_id = 0; unsigned.

Re: [Xen-devel] [RFC v2][PATCH] arm-acpi: Add ITS Support for Dom0

2017-06-13 Thread Julien Grall
On 13/06/17 12:02, Manish Jaggi wrote: Will the below code be ok? If you noticed, I didn't say this code is wrong. Instead I asked why you use the same ID. Meaning, is there anything in the DSDT requiring this value? + int tras_id = 0; unsigned. + list_for_each_entry(its_data, &host_its_l

Re: [Xen-devel] [RFC v2][PATCH] arm-acpi: Add ITS Support for Dom0

2017-06-13 Thread Manish Jaggi
Hi julien, On 6/9/2017 2:09 PM, Julien Grall wrote: On 09/06/2017 07:48, Manish Jaggi wrote: On 6/8/2017 7:28 PM, Julien Grall wrote: Hi, Hello Julien, Hello, +list_for_each_entry(its_data, &host_its_list, entry) +{ Pointless { +size += sizeof(struct acpi_madt_gener

Re: [Xen-devel] [RFC v2][PATCH] arm-acpi: Add ITS Support for Dom0

2017-06-09 Thread Julien Grall
On 09/06/2017 07:48, Manish Jaggi wrote: On 6/8/2017 7:28 PM, Julien Grall wrote: Hi, Hello Julien, Hello, +list_for_each_entry(its_data, &host_its_list, entry) +{ Pointless { +size += sizeof(struct acpi_madt_generic_translator); +} Just for readability of code.

Re: [Xen-devel] [RFC v2][PATCH] arm-acpi: Add ITS Support for Dom0

2017-06-08 Thread Manish Jaggi
On 6/8/2017 7:28 PM, Julien Grall wrote: Hi, Hello Julien, Please CC all relevant maintainers. Sure. Will do in the next patch rev. On 08/06/17 14:03, Manish Jaggi wrote: Spurious newline This patch supports ITS in hardware domain, supports ITS in Xen when booting with ACPI. Signed-

Re: [Xen-devel] [RFC v2][PATCH] arm-acpi: Add ITS Support for Dom0

2017-06-08 Thread Julien Grall
Hi, Please CC all relevant maintainers. On 08/06/17 14:03, Manish Jaggi wrote: Spurious newline This patch supports ITS in hardware domain, supports ITS in Xen when booting with ACPI. Signed-off-by: Manish Jaggi --- Changes since v1: - Moved its specific code to gic-v3-its.c - fixed macr

[Xen-devel] [RFC v2][PATCH] arm-acpi: Add ITS Support for Dom0

2017-06-08 Thread Manish Jaggi
This patch supports ITS in hardware domain, supports ITS in Xen when booting with ACPI. Signed-off-by: Manish Jaggi --- Changes since v1: - Moved its specific code to gic-v3-its.c - fixed macros xen/arch/arm/domain_build.c | 6 ++-- xen/arch/arm/gic-v3-its.c| 75 +++