Re: [Xen-devel] [V8 2/4] x86/xsaves: enable xsaves/xrstors/xsavec in xen

2015-10-29 Thread Shuai Ruan
On Mon, Oct 26, 2015 at 08:03:55AM -0600, Jan Beulich wrote: > >>> On 23.10.15 at 11:48, wrote: > > This patch uses xsaves/xrstors/xsavec instead of xsaveopt/xrstor > > to perform the xsave_area switching so that xen itself > > can benefit from them when available. > >

Re: [Xen-devel] [V8 2/4] x86/xsaves: enable xsaves/xrstors/xsavec in xen

2015-10-29 Thread Jan Beulich
>>> On 29.10.15 at 08:58, wrote: > On Mon, Oct 26, 2015 at 08:03:55AM -0600, Jan Beulich wrote: >> >>> On 23.10.15 at 11:48, wrote: >> > This patch uses xsaves/xrstors/xsavec instead of xsaveopt/xrstor >> > to perform the xsave_area

Re: [Xen-devel] [V8 2/4] x86/xsaves: enable xsaves/xrstors/xsavec in xen

2015-10-29 Thread Shuai Ruan
On Thu, Oct 29, 2015 at 02:59:38AM -0600, Jan Beulich wrote: > >>> On 29.10.15 at 08:58, wrote: > > On Mon, Oct 26, 2015 at 08:03:55AM -0600, Jan Beulich wrote: > >> >>> On 23.10.15 at 11:48, wrote: > >> > This patch uses

Re: [Xen-devel] [V8 2/4] x86/xsaves: enable xsaves/xrstors/xsavec in xen

2015-10-29 Thread Jan Beulich
>>> On 29.10.15 at 10:47, wrote: > On Thu, Oct 29, 2015 at 02:59:38AM -0600, Jan Beulich wrote: >> >>> On 29.10.15 at 08:58, wrote: >> > Yes. I will use the exist function "hvm_save_cpu_msrs" to save this msr. I >> > intend to add save msr

Re: [Xen-devel] [V8 2/4] x86/xsaves: enable xsaves/xrstors/xsavec in xen

2015-10-29 Thread Andrew Cooper
On 29/10/15 09:47, Shuai Ruan wrote: > On Thu, Oct 29, 2015 at 02:59:38AM -0600, Jan Beulich wrote: > On 29.10.15 at 08:58, wrote: >>> On Mon, Oct 26, 2015 at 08:03:55AM -0600, Jan Beulich wrote: >>> On 23.10.15 at 11:48, wrote:

Re: [Xen-devel] [V8 2/4] x86/xsaves: enable xsaves/xrstors/xsavec in xen

2015-10-27 Thread Jan Beulich
>>> On 27.10.15 at 02:06, wrote: > On Mon, Oct 26, 2015 at 08:03:55AM -0600, Jan Beulich wrote: >> >>> On 23.10.15 at 11:48, wrote: >> > -a &= boot_cpu_data.x86_capability[X86_FEATURE_XSAVEOPT / 32]; >> > -if (

Re: [Xen-devel] [V8 2/4] x86/xsaves: enable xsaves/xrstors/xsavec in xen

2015-10-27 Thread Shuai Ruan
On Tue, Oct 27, 2015 at 02:13:03AM -0600, Jan Beulich wrote: > >> > + > >> > +((struct xsave_struct *)dest)->xsave_hdr.xstate_bv = xstate_bv; > >> > +((struct xsave_struct *)dest)->xsave_hdr.xcomp_bv = 0; > >> > >> Wouldn't it be more logical to also memcpy() the header? Which > >> would

Re: [Xen-devel] [V8 2/4] x86/xsaves: enable xsaves/xrstors/xsavec in xen

2015-10-26 Thread Shuai Ruan
On Mon, Oct 26, 2015 at 08:03:55AM -0600, Jan Beulich wrote: > >>> On 23.10.15 at 11:48, wrote: > > Signed-off-by: Shuai Ruan > > Reviewed-by: Andrew Cooper > > There were actual bugs fixed from v7 to v8, plus

Re: [Xen-devel] [V8 2/4] x86/xsaves: enable xsaves/xrstors/xsavec in xen

2015-10-26 Thread Jan Beulich
>>> On 23.10.15 at 11:48, wrote: > This patch uses xsaves/xrstors/xsavec instead of xsaveopt/xrstor > to perform the xsave_area switching so that xen itself > can benefit from them when available. > > For xsaves/xrstors/xsavec only use compact format. Add format

[Xen-devel] [V8 2/4] x86/xsaves: enable xsaves/xrstors/xsavec in xen

2015-10-23 Thread Shuai Ruan
This patch uses xsaves/xrstors/xsavec instead of xsaveopt/xrstor to perform the xsave_area switching so that xen itself can benefit from them when available. For xsaves/xrstors/xsavec only use compact format. Add format conversion support when perform guest os migration. Also, pv guest will not