>>> On 28.11.14 at 11:29, wrote:
>> > -if (!hvm_pse1gb_supported(d))
>>> +if (!hvm_pse1gb_supported(d) || paging_mode_shadow(d))
>>> *edx &= ~cpufeat_mask(X86_FEATURE_PAGE1GB);
>>
>>With
>>
>>#define hvm_pse1gb_supported(d) \
>>(cpu_has_page1gb && paging_mode_hap(d
>>>(cpu_has_page1gb && paging_mode_hap(d)) the change above is
>>> pointless. While, considering this, comments on
>>> v2 may have been misleading, you should have simply updated the patch
>>> description instead to clarify why the v2 change was okay even for the
>>> shadow mode case.
>> I c
On 28/11/14 10:29, Li, Liang Z wrote:
>>> -if (!hvm_pse1gb_supported(d))
>>> +if (!hvm_pse1gb_supported(d) || paging_mode_shadow(d))
>>> *edx &= ~cpufeat_mask(X86_FEATURE_PAGE1GB);
>> With
>>
>> #define hvm_pse1gb_supported(d) \
>>(cpu_has_page1gb && paging_mode_hap
>> -if (!hvm_pse1gb_supported(d))
>> +if (!hvm_pse1gb_supported(d) || paging_mode_shadow(d))
>> *edx &= ~cpufeat_mask(X86_FEATURE_PAGE1GB);
>
>With
>
>#define hvm_pse1gb_supported(d) \
>(cpu_has_page1gb && paging_mode_hap(d))
>the change above is pointless. While,
>>> On 28.11.14 at 04:28, wrote:
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -4287,7 +4287,7 @@ void hvm_cpuid(unsigned int input, unsigned int *eax,
> unsigned int *ebx,
> !host_tsc_is_safe() )
> *edx &= ~cpufeat_mask(X86_FEATURE_RDTSCP);
>
If hardware support the 1GB pages, expose the feature to guest by
default. Users don't have to use a 'cpuid= ' option in config fil
e to turn it on.
Signed-off-by: Liang Li
Signed-off-by: Yang Zhang
---
tools/libxc/xc_cpuid_x86.c | 3 +++
xen/arch/x86/hvm/hvm.c | 2 +-
2 files changed, 4 in
