flight 65569 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/65569/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-armhf-armhf-xl 11 guest-start fail REGR. vs. 65561
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 12 migrate-support-check fail never pass
version targeted for testing:
xen 40412e3c99722229f1ec93cd95fc8486d778f5df
baseline version:
xen eedecb3cf0b2ce1ffc2eb08f3c73f88d42c382c9
Last test of basis 65561 2015-12-08 14:00:48 Z 0 days
Testing same since 65569 2015-12-08 16:02:11 Z 0 days 1 attempts
------------------------------------------------------------
People who touched revisions under test:
George Dunlap <george.dun...@citrix.com>
Ian Campbell <ian.campb...@citrix.com>
Ian Jackson <ian.jack...@eu.citrix.com>
jobs:
build-amd64 pass
build-armhf pass
build-amd64-libvirt pass
test-armhf-armhf-xl fail
test-amd64-amd64-xl-qemuu-debianhvm-i386 pass
test-amd64-amd64-libvirt pass
------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images
Logs, config files, etc. are available at
http://logs.test-lab.xenproject.org/osstest/logs
Explanation of these reports, and of osstest in general, is at
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master
Test harness code can be found at
http://xenbits.xen.org/gitweb?p=osstest.git;a=summary
Not pushing.
------------------------------------------------------------
commit 40412e3c99722229f1ec93cd95fc8486d778f5df
Author: Ian Jackson <ian.jack...@eu.citrix.com>
Date: Wed Nov 18 15:34:54 2015 +0000
libxl: Fix bootloader-related virtual memory leak on pv build failure
The bootloader may call libxl__file_reference_map(), which mmap's the
pv_kernel and pv_ramdisk into process memory. This was only unmapped,
however, on the success path of libxl__build_pv(). If there were a
failure anywhere between libxl_bootloader.c:parse_bootloader_result()
and the end of libxl__build_pv(), the calls to
libxl__file_reference_unmap() would be skipped, leaking the mapped
virtual memory.
Ideally this would be fixed by adding the unmap calls to the
destruction path for libxl__domain_build_state. Unfortunately the
lifetime of the libxl__domain_build_state is opaque, and it doesn't
have a proper destruction path. But, the only thing in it that isn't
from the gc are these bootloader references, and they are only ever
set for one libxl__domain_build_state, the one which is
libxl__domain_create_state.build_state.
So we can clean up in the exit path from libxl__domain_create_*, which
always comes through domcreate_complete.
Remove the now-redundant unmaps in libxl__build_pv's success path.
This is XSA-160.
Signed-off-by: George Dunlap <george.dun...@citrix.com>
Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com>
Tested-by: George Dunlap <george.dun...@citrix.com>
Acked-by: Ian Campbell <ian.campb...@citrix.com>
(qemu changes not included)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
