Re: [Xen-devel] Xen checkpatch infrastructure design

2017-07-26 Thread Lars Kurth
rg>>, cardoe <car...@cardoe.com<mailto:car...@cardoe.com>>, Andrii Anisov <andrii_ani...@epam.com<mailto:andrii_ani...@epam.com>>, Lars Kurth <lars.kurth....@gmail.com<mailto:lars.kurth@gmail.com>>, Artem Mygaiev <artem_myga...@epam.com<mailto:artem_my

Re: [Xen-devel] Xen checkpatch infrastructure design

2017-07-26 Thread Iurii Artemenko
Hi Lars, > I was wondering how you deal with the gaps. I suppose these gaps could > possibly be covered in clang-format-diff.py > Of course this info may be out-of-date I assumed that everything is fine with clang-format and started with python script. Now I have checked both

Re: [Xen-devel] Xen checkpatch infrastructure design

2017-07-26 Thread Iurii Artemenko
Hello, Juergen > How does this work for a patch which is perfectly fine, while not > touched parts of the patched file are not? The tool should only > look at the added lines, not at those left unmodified. The tool looks at touched lines only since it works with unified diff and parse it. As

Re: [Xen-devel] Xen checkpatch infrastructure design

2017-07-24 Thread Juergen Gross
On 24/07/17 18:55, Iurii Artemenko wrote: > Hello Juergen, > > > I've started to work on checkpatch-like python script. I make it based > on clang-format-diff.py and it works as pre-commit hook. How does this work for a patch which is perfectly fine, while not touched parts of the patched

Re: [Xen-devel] Xen checkpatch infrastructure design

2017-07-24 Thread Iurii Artemenko
Hello Juergen, I've started to work on checkpatch-like python script. I make it based on clang-format-diff.py and it works as pre-commit hook. > The easiest way to accomplish that is a file in the repository's root > directory containing the necessary information. It will be named > "STYLES"

Re: [Xen-devel] Xen checkpatch infrastructure design

2017-07-24 Thread Lars Kurth
xen-devel <xen-de...@lists.xenproject.org<mailto:xen-de...@lists.xenproject.org>>, cardoe <car...@cardoe.com<mailto:car...@cardoe.com>>, Andrii Anisov <andrii_ani...@epam.com<mailto:andrii_ani...@epam.com>>, Lars Kurth <lars.kurth@gmail.com<mailto:lar

Re: [Xen-devel] Xen checkpatch infrastructure design

2017-07-24 Thread Andrii Anisov
Dear Lars, Juergen, On our site we are working on the checkpatch-like script quite a while. Iurii Artemenko, our integrator, will get back with details by the end of the day. On 24.07.17 14:44, Lars Kurth wrote: I don't have a view on this, but wanted to point the following docs which

Re: [Xen-devel] Xen checkpatch infrastructure design

2017-07-24 Thread Lars Kurth
CC'ing Doug Goldstein as he has been reviewing some of Ishani's work (see below) Both Andy Cooper and Doug Goldstein had done some groundwork earlier on this topic > On 24 Jul 2017, at 09:50, Juergen Gross wrote: > > On the Xen Developer Summit 2017 in Budapest we agreed to

[Xen-devel] Xen checkpatch infrastructure design

2017-07-24 Thread Juergen Gross
On the Xen Developer Summit 2017 in Budapest we agreed to add a script to the Xen repository capable to test patches for style correctness, similar to checkpatch.pl of the Linux kernel. This is a first draft of the interface visible to users and developers. Problem to solve