Cedric Bosdonnat writes ("Re: [Xen-devel] per-domain logging"):
> I now have a big lot of changes to use the LOG*D family through the
> libxl code. What should be the best way to submit that for review?
> I guess a giant commit won't be too easy to handle for review an
On Wed, Nov 09, 2016 at 11:27:34AM +0100, Cedric Bosdonnat wrote:
> Hi Wei, Ian,
>
> I now have a big lot of changes to use the LOG*D family through the libxl
> code.
> What should be the best way to submit that for review? I guess a giant commit
> won't be too easy to handle for review and maint
Hi Wei, Ian,
I now have a big lot of changes to use the LOG*D family through the libxl code.
What should be the best way to submit that for review? I guess a giant commit
won't be too easy to handle for review and maintenance, maybe I should have one
commit per changed file... any opinion on that?
On Thu, Oct 13, 2016 at 11:28:21AM +0200, Cedric Bosdonnat wrote:
> Hi Wei, Ian,
>
> In quite a number of places, the domid we have in the function calling LOG*
> may be the one of a stubdom. In the log we want to output the domid of the
> domain the user knows about. Would there be a way to get i
Hi Wei, Ian,
In quite a number of places, the domid we have in the function calling LOG*
may be the one of a stubdom. In the log we want to output the domid of the
domain the user knows about. Would there be a way to get it?
An example of that is do_pci_add. It has a libxl_is_stubdom call, sugges
On Mon, Oct 10, 2016 at 09:03:49AM +0200, Cedric Bosdonnat wrote:
> On Fri, 2016-10-07 at 15:09 +0100, Wei Liu wrote:
> > Instead of trying to change all the format strings I think it would be
> > better to have a new set of LOG macros that takes domid.
> >
> > Something like:
> > LOGEVD(ERROR,
On Fri, 2016-10-07 at 16:37 +0100, Ian Jackson wrote:
> > But let's step back a bit: have we agreed on the approach forward? This
> > thread doesn't seem to have a clear conclusion yet. Obviously I don't
> > want you to waste your writing code that's going to be threw away.
> >
> > If you're happ
On Fri, 2016-10-07 at 15:09 +0100, Wei Liu wrote:
> Instead of trying to change all the format strings I think it would be
> better to have a new set of LOG macros that takes domid.
>
> Something like:
> LOGEVD(ERROR, errno, domid, "");
Sounds good to me, even if LOGEVD will just concatenat
Wei Liu writes ("Re: [Xen-devel] per-domain logging"):
> Instead of trying to change all the format strings I think it would be
> better to have a new set of LOG macros that takes domid.
>
> Something like:
> LOGEVD(ERROR, errno, domid, "");
>
>
On Tue, Oct 04, 2016 at 11:14:52AM +0200, Cedric Bosdonnat wrote:
> Hi Ian and Wei,
>
> On Mon, 2016-09-19 at 16:23 +0100, Ian Jackson wrote:
> > Cedric Bosdonnat writes ("Re: [Xen-devel] per-domain logging"):
> > > On Thu, 2016-09-15 at 16:11 +0100, Wei Liu wr
Hi Ian and Wei,
On Mon, 2016-09-19 at 16:23 +0100, Ian Jackson wrote:
> Cedric Bosdonnat writes ("Re: [Xen-devel] per-domain logging"):
> > On Thu, 2016-09-15 at 16:11 +0100, Wei Liu wrote:
> > > IIRC there is already logfile abstraction inside libvirt -- can you
On Mon, Sep 19, 2016 at 04:23:06PM +0100, Ian Jackson wrote:
> Cedric Bosdonnat writes ("Re: [Xen-devel] per-domain logging"):
> > On Thu, 2016-09-15 at 16:11 +0100, Wei Liu wrote:
> > > IIRC there is already logfile abstraction inside libvirt -- can you just
> >
Cedric Bosdonnat writes ("Re: [Xen-devel] per-domain logging"):
> On Thu, 2016-09-15 at 16:11 +0100, Wei Liu wrote:
> > IIRC there is already logfile abstraction inside libvirt -- can you just
> > pass in a libvirt logfile fd and try to demux there?
>
> The a
On Thu, 2016-09-15 at 16:11 +0100, Wei Liu wrote:
> On Thu, Sep 15, 2016 at 03:50:25PM +0100, Wei Liu wrote:
> >
> > CC Ian who might have some ideas on this.
> >
> > On Wed, Sep 14, 2016 at 04:22:24PM +0200, Cedric Bosdonnat wrote:
> > >
> > > Hi all,
> > >
> > > I wanted to get libvirt's libx
On Thu, Sep 15, 2016 at 03:50:25PM +0100, Wei Liu wrote:
> CC Ian who might have some ideas on this.
>
> On Wed, Sep 14, 2016 at 04:22:24PM +0200, Cedric Bosdonnat wrote:
> > Hi all,
> >
> > I wanted to get libvirt's libxl driver have per-domain logs like all other
> > drivers. After
> > looking
CC Ian who might have some ideas on this.
On Wed, Sep 14, 2016 at 04:22:24PM +0200, Cedric Bosdonnat wrote:
> Hi all,
>
> I wanted to get libvirt's libxl driver have per-domain logs like all other
> drivers. After
> looking at the libxl and XenToolLogger it seems I'll need to add the feature
>
Hi all,
I wanted to get libvirt's libxl driver have per-domain logs like all other
drivers. After
looking at the libxl and XenToolLogger it seems I'll need to add the feature in
either libxl
XenToolLogger. Would anyone already have an idea how best to add API to allow
this?
Thanks for your hel
17 matches
Mail list logo
