Re: [Xen-devel] stubdom vtpm build failure in staging

2015-03-13 Thread Olaf Hering
and TPM_ALG_ID. -Quan -Original Message- From: Olaf Hering [mailto:o...@aepfle.de] Sent: Wednesday, February 11, 2015 11:21 PM To: Xu, Quan Cc: xen-devel@lists.xen.org Subject: Re: [Xen-devel] stubdom vtpm build failure in staging On Wed, Jan 28, Xu, Quan wrote: Thanks

Re: [Xen-devel] stubdom vtpm build failure in staging

2015-03-12 Thread Ian Campbell
On Thu, 2015-03-12 at 01:46 +, Xu, Quan wrote: I am still testing and fixing it. Sorry for that, I am not a full time open source developer. Regardless, you are expect to fix things which you broke in a timely manner, otherwise in the future I will just have to be more proactive about

Re: [Xen-devel] stubdom vtpm build failure in staging

2015-03-12 Thread Xu, Quan
) Delete redundant TPMI_RH_HIERARCHY_AUTH and TPM_ALG_ID. -Quan -Original Message- From: Olaf Hering [mailto:o...@aepfle.de] Sent: Wednesday, February 11, 2015 11:21 PM To: Xu, Quan Cc: xen-devel@lists.xen.org Subject: Re: [Xen-devel] stubdom vtpm build failure in staging On Wed, Jan

Re: [Xen-devel] stubdom vtpm build failure in staging

2015-03-11 Thread Ian Campbell
] stubdom vtpm build failure in staging On Fri, 2015-02-13 at 02:07 +, Xu, Quan wrote: I try to redefine tpm2_types.h, deleting 'UINT16, UINT32 ..' and changing 'TPM_HANDLE ...' to ' TPM2_HANDLE ..', Or, could you give some advice? Thanks. Perhaps make stubdom/vtpmmgr/types.h

Re: [Xen-devel] stubdom vtpm build failure in staging

2015-03-11 Thread Xu, Quan
: Re: [Xen-devel] stubdom vtpm build failure in staging On Fri, 2015-02-13 at 02:07 +, Xu, Quan wrote: I try to redefine tpm2_types.h, deleting 'UINT16, UINT32 ..' and changing 'TPM_HANDLE ...' to ' TPM2_HANDLE ..', Or, could you give some advice? Thanks. Perhaps

Re: [Xen-devel] stubdom vtpm build failure in staging

2015-02-25 Thread Ian Campbell
On Fri, 2015-02-13 at 02:07 +, Xu, Quan wrote: I try to redefine tpm2_types.h, deleting 'UINT16, UINT32 ..' and changing 'TPM_HANDLE ...' to ' TPM2_HANDLE ..', Or, could you give some advice? Thanks. Perhaps make stubdom/vtpmmgr/types.h with these and use it for both? Or switch to the

Re: [Xen-devel] stubdom vtpm build failure in staging

2015-02-12 Thread Xu, Quan
-Original Message- From: xen-devel-boun...@lists.xen.org [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Xu, Quan Sent: Friday, February 13, 2015 12:57 AM To: Olaf Hering Cc: xen-devel@lists.xen.org Subject: Re: [Xen-devel] stubdom vtpm build failure

Re: [Xen-devel] stubdom vtpm build failure in staging

2015-02-12 Thread Andrew Cooper
Subject: Re: [Xen-devel] stubdom vtpm build failure in staging On Wed, Jan 28, Xu, Quan wrote: Thanks, I will check and fix it tomorrow. It is 23:12 PM Pacific time now. Any progress? These typedefs are duplicated in stubdom/vtpmmgr/tcg.h and supported compilers do not cope with current

Re: [Xen-devel] stubdom vtpm build failure in staging

2015-02-11 Thread Olaf Hering
On Wed, Jan 28, Xu, Quan wrote: Thanks, I will check and fix it tomorrow. It is 23:12 PM Pacific time now. Any progress? These typedefs are duplicated in stubdom/vtpmmgr/tcg.h and supported compilers do not cope with current staging: # for i in `grep -w typedef stubdom/vtpmmgr/tcg.h | sed -n

Re: [Xen-devel] stubdom vtpm build failure in staging

2015-01-30 Thread Olaf Hering
On Thu, Jan 29, Ian Campbell wrote: This compiles for me on Debian with gcc 4.7.2-5. Same here. I'm honestly not sure what the C standard says about duplicate but identical typedefs -- Ian? How would that matter now? ;-) Old gcc can not deal with it, the commits cause a regression for

Re: [Xen-devel] stubdom vtpm build failure in staging

2015-01-29 Thread Olaf Hering
On Thu, Jan 29, Xu, Quan wrote: Maybe the root cause is the old GCC version in SLE_11_SP3/ openSUSE_11.4, or a CFLAG issue as Ian mentioned to. I can also build a SLE_11_SP3 virtual machine to check it in next week. The CFLAGS are identical, except two -W flags: --- 11.42015-01-29

Re: [Xen-devel] stubdom vtpm build failure in staging

2015-01-29 Thread Ian Campbell
On Thu, 2015-01-29 at 11:27 +0100, Olaf Hering wrote: On Thu, Jan 29, Olaf Hering wrote: Looks like old gcc can not handle two typedefs? Yes, this fails already: typedef unsigned char BYTE; typedef unsigned char BYTE; void f(int *v) { *v *= *v; } t.c:2:23: error: redefinition of

Re: [Xen-devel] stubdom vtpm build failure in staging

2015-01-29 Thread Olaf Hering
On Thu, Jan 29, Olaf Hering wrote: Looks like old gcc can not handle two typedefs? Yes, this fails already: typedef unsigned char BYTE; typedef unsigned char BYTE; void f(int *v) { *v *= *v; } t.c:2:23: error: redefinition of typedef 'BYTE' t.c:1:23: note: previous declaration of 'BYTE' was

[Xen-devel] stubdom vtpm build failure in staging

2015-01-28 Thread Olaf Hering
Current staging fails in the install-stubdom target: ... [ 488s] tpm2_types.h:86: error: redefinition of typedef 'BYTE' [ 488s] tcg.h:404: error: previous declaration of 'BYTE' was here [ 488s] tpm2_types.h:87: error: redefinition of typedef 'BOOL' [ 488s] tcg.h:405: error: previous

Re: [Xen-devel] stubdom vtpm build failure in staging

2015-01-28 Thread Xu, Quan
Thanks, I will check and fix it tomorrow. It is 23:12 PM Pacific time now. Thanks Quan -Original Message- From: Olaf Hering [mailto:o...@aepfle.de] Sent: Wednesday, January 28, 2015 11:09 PM To: xen-devel@lists.xen.org Cc: Xu, Quan Subject: stubdom vtpm build failure in staging